feat(review): add structural observations section to review output#449
Open
kevglynn wants to merge 1 commit into
Open
feat(review): add structural observations section to review output#449kevglynn wants to merge 1 commit into
kevglynn wants to merge 1 commit into
Conversation
The tag-and-line format catches line-level cuts but misses structural over-engineering (unnecessary wrappers, misplaced abstractions). Blind experiment evidence: ponytail-review said 'Lean already. Ship.' on code with 4 genuine wrapper-layer issues. Section 2 — Structural observations captures patterns that don't reduce to a single tagged line, like 'this wrapper shouldn't exist' or 'tests exercise the upstream library, not this code.' Strengthens the scope boundary to be explicit and non-optional. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ponytail-reviewoutput formatMotivation
Blind A/B experiment (10 independent reviewers) found that the tag-and-line format produces false negatives on structural YAGNI.
ponytail-reviewsaid "Lean already. Ship." on code with 4 genuine wrapper-layer issues because observations like "this wrapper shouldn't exist" don't fit theL<line>: <tag>format.The unstructured simplify lens caught 1 structural finding that ponytail-review missed entirely, despite ponytail-review having 3.2x higher signal density on line-level findings.
Changes
skills/ponytail-review/SKILL.md: Added Section 2 for free-form structural observations after the tagged findings and net-lines metric. Strengthened Boundaries to make scope non-optional.Evidence
Test plan
npm test)check-rule-copies.jspasses/ponytail-reviewon code with a wrapper layer — verify structural observation appearsMade with Cursor