Repository navigation
Conversation
|
Updates to Preview Branch (eng-1837-add-a-public-status-in-the-database) ↗︎
Tasks are run on every commit but only new migration files are pushed.
❌ Branch Error • Fri, 06 Nov 2026 17:56:22 UTC View logs for this Workflow Run ↗︎. |
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
2 times, most recently
from
June 5, 2026 15:29
425bdec to
ece1239
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
June 22, 2026 13:52
ece1239 to
3457d0c
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
June 29, 2026 21:06
3457d0c to
57eb25a
Compare
mdroidian
marked this pull request as draft
July 30, 2026 20:18
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
August 1, 2026 16:38
57eb25a to
4258f48
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
August 23, 2026 18:33
4258f48 to
9ba89b3
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
August 26, 2026 20:58
9ba89b3 to
4b6e181
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
August 26, 2026 21:43
4b6e181 to
dccec7a
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
August 26, 2026 21:56
dccec7a to
51d4cdc
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
September 18, 2026 14:04
51d4cdc to
fa2a57f
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
September 28, 2026 02:30
fa2a57f to
ac45012
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
October 4, 2026 01:07
ac45012 to
036e2e7
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
2 times, most recently
from
October 8, 2026 20:04
036e2e7 to
301bf0c
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
October 9, 2026 00:37
c08e8c5 to
6b46d34
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
October 20, 2026 14:17
79f2750 to
b6608c0
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
November 6, 2026 17:55
b6608c0 to
f95cef8
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
November 6, 2026 18:18
f95cef8 to
2ad91b8
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
November 6, 2026 19:26
2ad91b8 to
8455226
Compare
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
November 7, 2026 15:08
8455226 to
3596b0c
Compare
Entire-Checkpoint: 01M6SPX33R47W9VEFNZMXPV6AR
maparent
force-pushed
the
eng-1837-add-a-public-status-in-the-database
branch
from
November 12, 2026 16:16
3596b0c to
b4ab298
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/discourse-graphs/issue/ENG-1837/add-a-public-status-in-the-database
Reviewer brief
my_identity_accounts()(excludes the everyone pseudo-user) instead ofmy_user_accounts()(includes it). That choice decides whether a public grant counts as the caller's own: it counts for reading content, not for deleting grants, sharing a space, seeing real names or seeing emails.readerlevel: issue candidate.my_accountslists every account of a space with any public grant, so Obsidian'sfetchUserNameslist grows with each published space. Mapped in the accounts spec: Which accounts a caller can see.Verification
features/publicAccess.feature.pnpm ci:validatepassed.dbTypes.tsregenerated from the fresh database with no difference.Loom video
Scope check
$scope-checkagainst ENG-1837 and the final diff.Done When: authors reached only through a public grant show asanonymous #<id>;AgentIdentifiershows only through the caller's own grants; a check constraint keeps the everyone pseudo-user atreaderor below.SpaceAccessrow could make every caller an editor. The risks arrive with the pseudo-user itself.Standards check
$dg-pr-adherence-checkagainst the final diff and PR metadata.Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.🤖 Generated with Claude Code