Skip to content

ENG-1837 Add a public status in the database - #1106

Draft
maparent wants to merge 1 commit into
mainfrom
eng-1837-add-a-public-status-in-the-database
Draft

maparent wants to merge 1 commit into
mainfrom
eng-1837-add-a-public-status-in-the-database

Conversation

@maparent

@maparent maparent commented Jun 5, 2026 •

Copy link
Copy Markdown
Collaborator

https://linear.app/discourse-graphs/issue/ENG-1837/add-a-public-status-in-the-database

Reviewer brief

  • Review focus: where the change uses my_identity_accounts() (excludes the everyone pseudo-user) instead of my_user_accounts() (includes it). That choice decides whether a public grant counts as the caller's own: it counts for reading content, not for deleting grants, sharing a space, seeing real names or seeing emails.
  • Risk or follow-up:
    • Every logged-in user can list who has access to a space published at reader level: issue candidate.
    • my_accounts lists every account of a space with any public grant, so Obsidian's fetchUserNames list grows with each published space. Mapped in the accounts spec: Which accounts a caller can see.

Verification

  • Cucumber, full suite on a freshly reset database: 95 scenarios, 1035 steps passed. New scenarios in features/publicAccess.feature.
  • Each fix was reverted in the database by hand, and its scenario failed.
  • pnpm ci:validate passed. dbTypes.ts regenerated from the fresh database with no difference.

Loom video

Scope check

  • Ran $scope-check against ENG-1837 and the final diff.
  • Scope beyond Done When: authors reached only through a public grant show as anonymous #<id>; AgentIdentifier shows only through the caller's own grants; a check constraint keeps the everyone pseudo-user at reader or below.
  • Required now: without them, publishing exposes authors' names and emails to every caller, and one SpaceAccess row could make every caller an editor. The risks arrive with the pseudo-user itself.
  • Anyone affected or consulted: No. Decided by the author.
  • Decision: Linear comment on ENG-1837

Standards check

  • Ran $dg-pr-adherence-check against the final diff and PR metadata.

Local delegated full review

  • Ran a comprehensive review of the entire final diff in a subagent with a fresh context. Use $dg-delegated-full-review when no other full-review workflow is available.

🤖 Generated with Claude Code


Open in Devin Review

@linear-code

linear-code Bot commented Jun 5, 2026

Copy link
Copy Markdown

ENG-1837

@supabase

supabase Bot commented Jun 5, 2026 •

Copy link
Copy Markdown

Updates to Preview Branch (eng-1837-add-a-public-status-in-the-database) ↗︎

Deployments Status Updated
Database ✅ Fri, 06 Nov 2026 17:56:12 UTC
Services ✅ Fri, 06 Nov 2026 17:56:12 UTC
APIs ✅ Fri, 06 Nov 2026 17:56:12 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations ✅ Fri, 06 Nov 2026 17:56:18 UTC
Migrations ❌ Fri, 06 Nov 2026 17:56:21 UTC
Seeding ⏸️ Fri, 06 Nov 2026 17:55:59 UTC
Edge Functions ⏸️ Fri, 06 Nov 2026 17:55:59 UTC

❌ Branch Error • Fri, 06 Nov 2026 17:56:22 UTC

Remote migration versions not found in local migrations directory.

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

View 2 additional findings in Devin Review.

Open in Devin Review

@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch 2 times, most recently from 425bdec to ece1239 Compare June 5, 2026 15:29
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from ece1239 to 3457d0c Compare June 22, 2026 13:52
@vercel

vercel Bot commented Jun 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
discourse-graph Ready Ready Preview Nov 12, 2026 4:18pm UTC

Request Review

@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from 3457d0c to 57eb25a Compare June 29, 2026 21:06
@mdroidian
mdroidian marked this pull request as draft July 30, 2026 20:18
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from 57eb25a to 4258f48 Compare August 1, 2026 16:38
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from 4258f48 to 9ba89b3 Compare August 23, 2026 18:33
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from 9ba89b3 to 4b6e181 Compare August 26, 2026 20:58
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from 4b6e181 to dccec7a Compare August 26, 2026 21:43
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from dccec7a to 51d4cdc Compare August 26, 2026 21:56
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from 51d4cdc to fa2a57f Compare September 18, 2026 14:04
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from fa2a57f to ac45012 Compare September 28, 2026 02:30
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from ac45012 to 036e2e7 Compare October 4, 2026 01:07
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch 2 times, most recently from 036e2e7 to 301bf0c Compare October 8, 2026 20:04
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from c08e8c5 to 6b46d34 Compare October 9, 2026 00:37
@maparent
maparent changed the base branch from main to Restrict_my_accounts October 9, 2026 01:01
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from 79f2750 to b6608c0 Compare October 20, 2026 14:17
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from b6608c0 to f95cef8 Compare November 6, 2026 17:55
@maparent
maparent changed the base branch from Restrict_my_accounts to main November 6, 2026 17:59
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from f95cef8 to 2ad91b8 Compare November 6, 2026 18:18
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from 2ad91b8 to 8455226 Compare November 6, 2026 19:26
@maparent
maparent force-pushed the eng-1837-add-a-public-status-in-the-database branch from 8455226 to 3596b0c Compare November 7, 2026 15:08
Entire-Checkpoint: 01M6SPX33R47W9VEFNZMXPV6AR

This branch was successfully deployed

1 active deployment
Preview — b4ab2984 Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant