Repository navigation
ENG-2460 Restore database comments missing from migrations - #1612
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Updates to Preview Branch (eng-2460-restore-database-comments-missing-from-migrations) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
| @@ -0,0 +1,31 @@ | |||
| SET local check_function_bodies = off; | |||
|
|
|||
| CREATE EXTENSION "pg_cron"; | |||
There was a problem hiding this comment.
🔴 Existing scheduler blocks comment migration
On a database with pg_cron installed, CREATE EXTENSION fails before any comments are applied. The declarative schema already installs that extension, so this blocks migration on those databases.
| CREATE EXTENSION "pg_cron"; | |
| CREATE EXTENSION IF NOT EXISTS "pg_cron" WITH SCHEMA pg_catalog; |
Was this helpful? React with 👍 or 👎 to provide feedback.
5ea23aa to
df45e88
Compare
df45e88 to
e081d7e
Compare
e081d7e to
6b00cc7
Compare
Reviewer brief
dbdiffscripts off the deprecated--use-pg-schemaengine #1611 (ENG-2461), which provides thedbdiffengine used to generate this migration. Review after ENG-2461 Move thedbdiffscripts off the deprecated--use-pg-schemaengine #1611, or read only the last commit.SpaceAccess.permissions. The ticket counted 16 because ENG-2446 dropped some per-row account functions since then.CREATE EXTENSION "pg_cron"andCOMMENT ON EXTENSION "pg_cron"lines from the generated file. They appear only because this branch doesn't include ENG-2459 (ENG-2459 Remove the unusedpg_cronandpg_stat_monitorextensions #1609), which removespg_cronfromextensions.sql. Production doesn't havepg_cron, and this migration must not install it.Verification
pnpm run dbdiffreports onlyCREATE EXTENSION "pg_cron"and its comment. Both go away once ENG-2459 is merged, which leaves noCOMMENTlines.Loom video
https://www.loom.com/share/c85ab554ec224f89af3f4b06f8c2c40d
Scope check
$scope-checkagainst ENG-2460 and the final diff.Done When: None.Standards check
$dg-pr-adherence-checkagainst the final diff and PR metadata.Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.https://linear.app/discourse-graphs/issue/ENG-2460/restore-database-comments-missing-from-migrations
🤖 Generated with Claude Code