Skip to content

ENG-2460 Restore database comments missing from migrations - #1612

Merged
maparent merged 1 commit into
mainfrom
eng-2460-restore-database-comments-missing-from-migrations
Nov 11, 2026
Merged

maparent merged 1 commit into
mainfrom
eng-2460-restore-database-comments-missing-from-migrations

Conversation

@maparent

@maparent maparent commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Reviewer brief

Verification

  • With the migration in place, pnpm run dbdiff reports only CREATE EXTENSION "pg_cron" and its comment. Both go away once ENG-2459 is merged, which leaves no COMMENT lines.

Loom video

https://www.loom.com/share/c85ab554ec224f89af3f4b06f8c2c40d

Scope check

  • Ran $scope-check against ENG-2460 and the final diff.
  • Scope beyond Done When: None.

Standards check

  • Ran $dg-pr-adherence-check against the final diff and PR metadata.

Local delegated full review

  • Ran a comprehensive review of the entire final diff in a subagent with a fresh context. Use $dg-delegated-full-review when no other full-review workflow is available.

https://linear.app/discourse-graphs/issue/ENG-2460/restore-database-comments-missing-from-migrations


Devin Review

🤖 Generated with Claude Code

@vercel

vercel Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
discourse-graph Ready Ready Preview Nov 11, 2026 4:58pm UTC

Request Review

@linear-code

linear-code Bot commented Nov 7, 2026

Copy link
Copy Markdown

ENG-2460

@supabase

supabase Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Updates to Preview Branch (eng-2460-restore-database-comments-missing-from-migrations) ↗︎

Deployments Status Updated
Database ✅ Wed, 11 Nov 2026 16:57:15 UTC
Services ✅ Wed, 11 Nov 2026 16:57:15 UTC
APIs ✅ Wed, 11 Nov 2026 16:57:15 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations ✅ Wed, 11 Nov 2026 16:57:16 UTC
Migrations ⚠️ Wed, 11 Nov 2026 16:57:16 UTC
Seeding ✅ Wed, 11 Nov 2026 16:57:16 UTC
Edge Functions ✅ Wed, 11 Nov 2026 16:57:18 UTC

⚠️ Warning — Applied out-of-order migrations: [packages/database/supabase/migrations/20261106130000_explicit_privileges.sql]


View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

@@ -0,0 +1,31 @@
SET local check_function_bodies = off;

CREATE EXTENSION "pg_cron";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Existing scheduler blocks comment migration

On a database with pg_cron installed, CREATE EXTENSION fails before any comments are applied. The declarative schema already installs that extension, so this blocks migration on those databases.

Suggested change
CREATE EXTENSION "pg_cron";
CREATE EXTENSION IF NOT EXISTS "pg_cron" WITH SCHEMA pg_catalog;

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@maparent
maparent force-pushed the eng-2460-restore-database-comments-missing-from-migrations branch from 5ea23aa to df45e88 Compare November 7, 2026 18:14
@maparent
maparent force-pushed the eng-2460-restore-database-comments-missing-from-migrations branch from df45e88 to e081d7e Compare November 7, 2026 18:17
@maparent
maparent requested a review from mdroidian November 7, 2026 22:53
Base automatically changed from eng-2461-move-the-dbdiff-scripts-off-the-deprecated-use-pg to main November 11, 2026 16:46
@maparent
maparent force-pushed the eng-2460-restore-database-comments-missing-from-migrations branch from e081d7e to 6b00cc7 Compare November 11, 2026 16:56
@maparent
maparent merged commit dc65dae into main Nov 11, 2026
8 checks passed
@maparent
maparent deleted the eng-2460-restore-database-comments-missing-from-migrations branch November 11, 2026 18:52

This branch was successfully deployed

1 active deployment
Preview — 6b00cc7d Deployed Nov 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants