Repository navigation
ENG-2467 Lint all schema files with sqruff, including the large ones - #1614
Merged
maparent merged 1 commit intoNov 11, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Updates to Preview Branch (eng-2467-lint-all-schema-files-with-sqruff-including-the) ↗︎
Tasks are run on every commit but only new migration files are pushed.
❌ Branch Error • Wed, 11 Nov 2026 18:59:33 UTC View logs for this Workflow Run ↗︎. |
maparent
force-pushed
the
eng-2467-lint-all-schema-files-with-sqruff-including-the
branch
from
November 8, 2026 15:22
ea4055e to
fd11bcc
Compare
mdroidian
approved these changes
Nov 11, 2026
maparent
force-pushed
the
eng-2467-lint-all-schema-files-with-sqruff-including-the
branch
from
November 11, 2026 18:58
fd11bcc to
024eaaa
Compare
maparent
deleted the
eng-2467-lint-all-schema-files-with-sqruff-including-the
branch
November 11, 2026 19:03
3 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer brief
my_accountsview (account.sql) is the only hand edit, and the migration re-creates the view with it. Everything else is sqruff autofix: whitespace, and keyword case (TRUE→true,NEW→new).Verification
tsx scripts/lintSchemas.ts: passes; sqruff processes all 11 files insupabase/schemas.main: apart from the alias, only keyword case changes; no string literal, quoted identifier or$$body changed.pnpm run dbdiff: without the migration it printedDROP VIEW/CREATE VIEW public.my_accounts, because Postgres stores the alias in the view's definition. With the migration, that is gone and only the same 81GRANTlines remain, which are known false reports from the--use-pg-schemaengine.Loom video
https://www.loom.com/share/193f777b6dc14a74a94cd16b6b342353
Scope check
$scope-checkagainst ENG-2467 and the final diff.Done When: a migration that re-creates themy_accountsview.Standards check
$dg-pr-adherence-checkagainst the final diff and PR metadata.Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.https://linear.app/discourse-graphs/issue/ENG-2467/lint-all-schema-files-with-sqruff-including-the-large-ones
🤖 Generated with Claude Code