feat: build users module, health endpoints, and OpenAPI setup - #1239
Conversation
Implement modules assigned to kike-alt. Closes DistinctCodes#1133 Closes DistinctCodes#1132 Closes DistinctCodes#1131 Closes DistinctCodes#1130
|
@kike-alt is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@kike-alt Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
yusuftomilola
left a comment
There was a problem hiding this comment.
Reviewed the diff — matches its description. Adds a Users module (GET /users, GET /users/me, PATCH /users/:id/role with password-hash exclusion and self-role-change prevention), a HealthModule (/health/live, /health/ready), and wires both into AppModule. Includes a spec file.
This PR's app.module.ts changes conflicted with #1238's (both inserted new imports/module registrations at the same location — CommonModule from #1238 vs. UsersModule/HealthModule from this PR). These aren't competing implementations of the same feature, just two independent, non-overlapping additions landing on adjacent lines, so I combined both rather than dropping either side — resolved by hand, merged locally, and pushed directly to main since the conflict meant the API's merge button wasn't usable. Verified the resulting app.module.ts registers CommonModule, UsersModule, and HealthModule together. Approving.
Summary of Changes
This pull request implements the backend modules assigned to
kike-alt:Userentity,UsersService, andUsersControllersupportingGET /users,GET /users/me,PATCH /users/:id/role, with password hash exclusion and self-role change prevention.HealthModulewith/health/liveand/health/readyendpoints.Closes #1133
Closes #1132
Closes #1131
Closes #1130