Skip to content

feat: build users module, health endpoints, and OpenAPI setup - #1239

Merged
yusuftomilola merged 1 commit into
DistinctCodes:mainfrom
kike-alt:feature/kike-alt-assigned-fixes
Jul 28, 2026
Merged

feat: build users module, health endpoints, and OpenAPI setup#1239
yusuftomilola merged 1 commit into
DistinctCodes:mainfrom
kike-alt:feature/kike-alt-assigned-fixes

Conversation

@kike-alt

Copy link
Copy Markdown
Contributor

Summary of Changes

This pull request implements the backend modules assigned to kike-alt:

Closes #1133
Closes #1132
Closes #1131
Closes #1130

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

@kike-alt is attempting to deploy a commit to the naijabuz's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jul 28, 2026

Copy link
Copy Markdown

@kike-alt Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@yusuftomilola yusuftomilola left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff — matches its description. Adds a Users module (GET /users, GET /users/me, PATCH /users/:id/role with password-hash exclusion and self-role-change prevention), a HealthModule (/health/live, /health/ready), and wires both into AppModule. Includes a spec file.

This PR's app.module.ts changes conflicted with #1238's (both inserted new imports/module registrations at the same location — CommonModule from #1238 vs. UsersModule/HealthModule from this PR). These aren't competing implementations of the same feature, just two independent, non-overlapping additions landing on adjacent lines, so I combined both rather than dropping either side — resolved by hand, merged locally, and pushed directly to main since the conflict meant the API's merge button wasn't usable. Verified the resulting app.module.ts registers CommonModule, UsersModule, and HealthModule together. Approving.

@yusuftomilola
yusuftomilola merged commit fbabd0c into DistinctCodes:main Jul 28, 2026
2 of 9 checks passed
@grantfox-oss grantfox-oss Bot mentioned this pull request Jul 28, 2026
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants