feat: monolith split plan, event migration, storage TTL audit, overflow audit - #1557
Merged
Conversation
…erflow audit - SC-08: Created MONOLITH_SPLIT_PLAN.md identifying 6 extraction groups with dependency graph and phased approach; expanded membership_token crate with full token/transfer/metadata/renewal/pause logic; created staking_rewards crate; added 4 stub crates (subscription_tier, attendance_batch, token_upgrade, pause_control) - SC-09: Created EVENT_MIGRATION.md with full inventory of all event publish calls across all 5 contracts, migration patterns, and priority recommendations; added #[contractevent] annotations to resource_credits (CreditsMinted, CreditsTransferred, CreditsSpent) and workspace_booking (ContractInitialized, WorkspaceRegistered, WorkspaceAvailabilityChanged, WorkspaceRateChanged, WorkspaceBooked, BookingCancelled, BookingCompleted) - SC-10: Created STORAGE_AUDIT.md documenting all persistent storage entries across all contracts; added TTL bump/extend_ttl calls to every persistent write path in resource_credits, workspace_booking, membership_token (standalone + monolith), subscription, attendance_log, fractionalization, staking, staking_rewards, and upgrade modules - SC-11: Created OVERFLOW_AUDIT.md documenting all arithmetic operations; replaced unchecked arithmetic with checked_add/checked_mul in resource_credits and workspace_booking; replaced += with saturating_add for analytics counters in subscription, version increments in membership_token, and duration accumulators in attendance_log Closes DistinctCodes#1524, DistinctCodes#1525, DistinctCodes#1526, DistinctCodes#1527
|
@BigBen-7 is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@NteinPrecious Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
yusuftomilola
approved these changes
Jul 27, 2026
yusuftomilola
left a comment
Collaborator
There was a problem hiding this comment.
Impressive architectural improvements! Monolith split planning, event migration, storage TTL audit, and overflow audit show strong attention to scalability and security.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1524, Closes #1525, Closes #1526, Closes #1527