Repository navigation
fix: scroll to top when changing routes - #21
Draft
danieldanielecki wants to merge 2 commits into
Draft
danieldanielecki wants to merge 2 commits into
danieldanielecki wants to merge 2 commits into
Conversation
The standalone router never applied RoutingModule's scroll restoration, so SPA navigations kept the previous viewport offset. Restore to top on NavigationEnd and align router config with that behavior. Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>
Standalone withInMemoryScrolling does not populate ROUTER_CONFIGURATION, so drop that assertion and drive the AppComponent test through a real navigation. Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15: after SPA navigation, the viewport stayed wherever the previous page was scrolled (often the bottom on long pages / mobile).
Cause: The app bootstraps with standalone
provideRouter(routes)inapp.config.ts.scrollPositionRestorationlived only on unusedRoutingModule, so Angular never reset scroll on route change.html, body { height: 100%; overflow-x: hidden }can also makebodythe scroller, sowindowrestoration alone is not enough.Fix:
withInMemoryScrolling({ scrollPositionRestoration: 'top' })on the live standalone routerRoutingModuleto'top'NavigationEnd, resetwindow,documentElement, andbodyscroll (browser only)Test plan
AppComponentscrolls to top on navigation (ng testincludeapp.component.spec.ts+app-routing.module.spec.ts: 6 passed)RoutingModuleusesscrollPositionRestoration: 'top'/, navigate to/about-us, viewport is at top (e2e/scroll.spec.tspassed)