Skip to content

feat: add makefile for standardized development commands#226

Merged
DogukanUrker merged 4 commits into
mainfrom
feat/223-create-makefile
Jan 29, 2026
Merged

feat: add makefile for standardized development commands#226
DogukanUrker merged 4 commits into
mainfrom
feat/223-create-makefile

Conversation

@DogukanUrker
Copy link
Copy Markdown
Owner

@DogukanUrker DogukanUrker commented Jan 29, 2026

Summary

  • Create Makefile with development commands (install, run, test, lint, ci, clean)
  • Add ruff as dev dependency for linting/formatting
  • Update GitHub workflows to use Makefile targets
  • Update documentation (README.md, AGENTS.md, tests/README.md)

Makefile Commands

make help          # Show all available commands
make install       # Install all dependencies (app + dev + test + Playwright)
make install-app   # Install app dependencies only
make run           # Run the Flask application
make test          # Run E2E tests (parallel)
make test-slow     # Run tests with browser visible (slow-mo)
make lint          # Format and lint code (auto-fix)
make ci            # Run CI checks
make clean         # Remove cache files

Test plan

  • make help shows all commands
  • make install installs dependencies
  • make lint formats and lints code
  • make ci runs CI checks

Closes #223

Summary by CodeRabbit

  • Documentation

    • Updated setup, testing, and development instructions across all guides to reflect Makefile-based workflow.
    • Added new "Makefile Commands" section documenting available development targets.
  • Chores

    • Introduced Makefile at project root to centralize and simplify development commands (install, run, test, lint, ci, clean).
    • Updated CI/CD workflows to use Makefile targets instead of direct command invocations.
    • Added dev dependency group to project configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

- Create Makefile with targets: install, install-app, run, test, test-slow, lint, ci, clean
- Add ruff as dev dependency in pyproject.toml
- Update GitHub workflows to use Makefile commands
- Update README.md, AGENTS.md, and tests/README.md with Makefile usage
@DogukanUrker DogukanUrker changed the title add makefile for standardized development commands feat: add makefile for standardized development commands Jan 29, 2026
@DogukanUrker DogukanUrker self-assigned this Jan 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 29, 2026

Warning

Rate limit exceeded

@DogukanUrker has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

A Makefile is introduced at the repository root defining development, testing, and CI targets. GitHub Actions workflows, documentation, and project configuration are updated to use make commands instead of direct uv invocations, centralizing command orchestration.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/code-quality.yaml, .github/workflows/e2e-tests.yaml
Replaced explicit Python/uv setup steps with centralized make install and make ci/make test targets; added Makefile to workflow path triggers; refined cache configuration to use astral-sh/setup-uv with pyproject.toml cache dependency.
Makefile Definition
Makefile
New file introducing targets for help, install, install-app, run, test, test-slow, lint, ci, and clean; uses variables APP_DIR, TESTS_DIR, and UV for consistent command orchestration across development and CI workflows.
Documentation
README.md, AGENTS.md, tests/README.md
Updated Quick Start, setup, and testing instructions to reference Makefile targets; replaced raw uv command sequences with simplified make invocations.
Project Dependencies
app/pyproject.toml
Added optional dev dependency group containing ruff>=0.9.0.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A Makefile hops into view,
Commands now neat, old ways bid adieu,
make install, make test with ease,
Gone are the uv invocations, if you please!
Simplicity reigns, workflows align,
This orchestration tastes fine! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: add makefile for standardized development commands' clearly summarizes the main change—adding a Makefile for standardized development commands.
Description check ✅ Passed The description is well-structured, covering summary, makefile commands, test plan, and issue closure, though it deviates slightly from the template by omitting 'Proposed Changes' section.
Linked Issues check ✅ Passed The PR fully addresses issue #223 by creating a Makefile with standardized development commands (install, run, test, lint, ci, clean) as requested.
Out of Scope Changes check ✅ Passed All changes align with the scope of issue #223; workflow and documentation updates are necessary supporting changes to integrate the Makefile into the development workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DogukanUrker DogukanUrker merged commit 9a69dca into main Jan 29, 2026
2 of 3 checks passed
@DogukanUrker DogukanUrker deleted the feat/223-create-makefile branch January 29, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create a makefile

1 participant