Add dynamo-release-notes skill, trim dynamo-content-designer - #17298
Add dynamo-release-notes skill, trim dynamo-content-designer#17298jasonstratton wants to merge 2 commits into
Conversation
Split the release-notes curation-and-publish workflow out of dynamo-content-designer into its own skill: it's a multi-step process (curate, sweep, flag ambiguous calls, draft, cross-check against already-published content, validate, publish, verify) rather than a sentence-level writing task. dynamo-content-designer now redirects release-notes requests to the new skill instead of covering them itself.
There was a problem hiding this comment.
Pull request overview
This PR restructures Claude Code tooling in Dynamo by extracting the release-notes curation/publishing workflow out of dynamo-content-designer into a dedicated dynamo-release-notes skill, and updating repo guidance accordingly.
Changes:
- Added a new
dynamo-release-notesskill with supporting assets (curation rules, style guide, and wiki publishing plumbing). - Updated
dynamo-content-designerto remove embedded release-notes guidance and redirect release-notes requests to the new skill. - Updated
AGENTS.mdto reflect the new skill lineup and revised scope ofdynamo-content-designer.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| AGENTS.md | Updates the documented list of available skills and clarifies content-designer scope. |
| .claude/skills/dynamo-release-notes/SKILL.md | Introduces the new release-notes workflow skill and its end-to-end process. |
| .claude/skills/dynamo-release-notes/assets/curation-rules.md | Defines inclusion/dedup/security/breaking-change/credit/category rules for release notes curation. |
| .claude/skills/dynamo-release-notes/assets/style-guide.md | Provides sentence-level guidance for writing release-note bullets. |
| .claude/skills/dynamo-release-notes/assets/wiki-publish-plumbing.md | Documents a safe Windows-friendly git plumbing workflow for editing the wiki. |
| .claude/skills/dynamo-content-designer/SKILL.md | Removes release-notes responsibility and redirects to dynamo-release-notes. |
| .claude/skills/dynamo-content-designer/assets/release-notes.md | Removes the old embedded release-notes guidance (moved/replaced by the new skill’s assets). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| description: Curate, sweep, draft, cross-check, and publish the "### {version}" section | ||
| of the Dynamo GitHub wiki Release-Notes page, starting from the raw | ||
| ReleaseNotes_{X.Y.Z}.md generator dump. Use when compiling release notes for a Dynamo | ||
| release, deciding which PRs belong in a release's notes, or inserting/updating content | ||
| on the Release-Notes wiki page (https://github.com/DynamoDS/Dynamo/wiki/Release-Notes). |
| stage the entire wiki as deleted. Run `git status` immediately before creating the | ||
| commit and confirm it shows only the intended single-file change. **Ask the requester | ||
| to explicitly confirm before pushing** — a wiki push has no PR or review gate and is |
| ``` | ||
| git diff-tree <old-tree-sha> <new-tree-sha> | ||
| ``` |
|
|
||
| - User mentions writing documentation: "write a doc", "write an error message", "create a tutorial", "write up", "draft content" | ||
| - User mentions specific doc types: "blog post", "Primer article", "release notes", "feature documentation," "notification message" | ||
| - User mentions specific doc types: "blog post", "Primer article", "feature documentation," "notification message" |
edwin-vasquez-ucaldas
left a comment
edwin-vasquez-ucaldas
left a comment
There was a problem hiding this comment.
LGTM.
Only pending to address the copilot comments, I think just related with format/metadata/wrapper consistency issues and those comments make sense for me.
Fixes invalid multi-line YAML description in dynamo-release-notes frontmatter, resolves a git-status contradiction between the SKILL.md publish step and the plumbing recipe (the recipe never touches the index, so status should be clean/empty, not "single-file change"), fills in the undefined old-tree-sha in the diff-tree verification command, and removes a stray comma in dynamo-content-designer's trigger list.
|
RobertGlobant20
left a comment
RobertGlobant20
left a comment
There was a problem hiding this comment.
Code review of the release-notes skill split. No product code, but the documented publish procedure has two defects that make it unrunnable as written, plus a CI-blocking wrapper drift. Findings below; happy to push fixes if useful.
| --- | ||
| name: dynamo-content-designer | ||
| description: Technical writing specialist for Dynamo product documentation, blog posts, tutorials, educational content, release notes, and release documentation. Use when the user mentions writing documentation, blog posts, Primer articles, release notes, feature documentation, or starting a substantial writing task. | ||
| description: Technical writing specialist for Dynamo product documentation, blog posts, tutorials, and educational content. Use when the user mentions writing documentation, blog posts, Primer articles, feature documentation, or starting a substantial writing task. For release notes specifically (curating, drafting, and publishing the wiki Release-Notes page), use the dynamo-release-notes skill instead. |
There was a problem hiding this comment.
This description: change desyncs .github/agents/dynamo-content-designer.agent.md, which isn't in the PR — validate_agent_skill_wrappers will fail with "Wrapper drift detected".
Run pwsh .github/scripts/sync_agent_wrappers.ps1 and commit the wrapper.
| - Writing or polishing release-notes *prose in isolation*, with the PR list already | ||
| decided and no publishing step involved — use `dynamo-content-designer` and its | ||
| [style guide](./assets/style-guide.md) directly. |
There was a problem hiding this comment.
Circular redirect: content-designer routes release notes here, this routes prose back to it "and its style guide" — deleted in this PR, and the link resolves into dynamo-release-notes/assets/.
Drop the bullet, or point at the local style guide without naming the other skill.
| working tree, so run `git status` immediately before `commit-tree` and confirm it | ||
| shows a clean, empty status (no staged/unstaged changes at all) — anything else means | ||
| the index got populated and you should stop and re-derive the tree diff. **Ask the |
There was a problem hiding this comment.
This gate can never pass, so step 8 halts every run: --no-checkout leaves the index empty, so git status always shows the whole wiki staged-deleted (reproduced) — which wiki-publish-plumbing.md:59-74 itself documents as expected.
Drop the git status gate; step 5's diff-tree is the real check. Same fix at plumbing:76-80.
| ``` | ||
| 2. **Extract just the target file** from the current tip, without touching anything else: | ||
| ``` | ||
| git show HEAD:Release-Notes.md > Release-Notes.md |
There was a problem hiding this comment.
PowerShell > adds a BOM and converts LF→CRLF, so a no-edit round-trip already changes the blob (bfa65511 → 514ab4eb) — and step 5 still passes, since one entry is all that changed. Every release ships a BOM and a full-file diff.
Use cmd /c "git show HEAD:Release-Notes.md > Release-Notes.md", then verify git rev-parse HEAD:Release-Notes.md equals git hash-object Release-Notes.md before editing.
| ``` | ||
| git ls-tree HEAD > tree.txt | ||
| # edit tree.txt: replace the old blob SHA for Release-Notes.md with the new one | ||
| git mktree < tree.txt |
There was a problem hiding this comment.
Bash-isms in a Windows doc, all verified failing in PS 5.1: git mktree < tree.txt → "The '<' operator is reserved"; line 33's > has the BOM issue noted above; line 56's curl -s hits the Invoke-WebRequest alias.
Wrap the redirects in cmd /c "..." and use curl.exe -s.
Purpose
Splits the release-notes curation-and-publish workflow out of the
dynamo-content-designerClaude Code skill into its own dedicated skill,dynamo-release-notes. Publishing a release's wiki notes turned out to be a multi-step process (curate the raw generator dump, run security/breaking-change/attribution/category sweeps, flag ambiguous calls for a human decision, draft prose, cross-check against everything already published to avoid duplicating an earlier patch release's notes, validate links/content, safely edit the wiki repo, verify post-publish) rather than a sentence-level writing task — worth its own skill rather than a subsection of a general content-writing skill.dynamo-content-designernow redirects release-notes requests to the new skill instead of covering them itself.This is Claude Code tooling only (
.claude/skills/,AGENTS.md) — no product code changes.Declarations
Release Notes
N/A
Reviewers
(none assigned yet)
FYIs
N/A