DYN-10569: Only warn on Python port removal when the port has custom properties

[koeylai-adsk]

Purpose

DYN-10569: The "Remove Port?" confirmation dialog warned that "Your custom port
properties will be lost once the port is removed" on every input-port removal
from a Python Script node — including freshly added ports that had never been
modified. This created friction and implied changes existed where none did.

The dialog is now gated on whether the port actually carries user customizations.

Key changes:

• New PythonNodeBase.HasCustomInputPortProperties(int index) in
  src/Libraries/PythonNodeModels/PythonNode.cs. Compares the port's live Name
  and ToolTip against the generated defaults (GetInputName/GetInputTooltip)
  for that index; any difference means the user renamed the port or edited its
  description via the port context menu's Rename Port dialog.
• src/DynamoCoreWpf/Controls/DynamoNodeButton.cs consults it before prompting.
  Removal always targets the last input port, so only that port is inspected.
  This also suppresses the prompt when there is no port left to remove
  (previously the dialog appeared even though nothing would be removed).

No public API surface changed — the new member is internal, reachable from
DynamoCoreWpf and the test assemblies through existing InternalsVisibleTo
attributes. PublicAPI.Unshipped.txt is therefore untouched, confirmed by a
CI-parity build (Release + public-API analyzers) reporting no RS0016/RS0017.

Known limitation, documented in-code: the index-to-default mapping holds for
PythonNode only. PythonStringNode prepends a fixed script port and overrides
GetInputIndex() to subtract one, so its ports are offset. It is unaffected here
because the caller narrows to is PythonNode, and its pre-existing behaviour
(never warning on removal) is unchanged. Widening the type test would require
correcting the mapping first.

Testing:

• test/Libraries/DynamoPythonTests/PythonEditTests.cs — 9 tests / 15 cases over
  the helper: unmodified, renamed, description-only, case-only edits, out-of-range
  and zero-port indices, and save/reload round-trips.
• test/DynamoCoreWpfTests/PythonNodeRemovePortWarningTests.cs (new) — 6 tests
  driving the real - button on a realized NodeView with a mocked
  MessageBoxService.IMessageBox, covering: no prompt for an unmodified port,
  prompt for a renamed or re-described port, correct port targeting when an
  earlier port is the customized one, and that Cancel aborts the removal.

Declarations

Check these if you believe they are true

• Is documented according to the standards
• The level of testing this PR includes is appropriate
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Release Notes

Removing an unmodified input port from a Python Script node no longer shows the
"Remove Port?" confirmation dialog; the warning now appears only when the port has
a custom name or description that would be lost.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10569

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[jasonstratton]

LGTM

[jasonstratton]

@koeylai-adsk Merged!