Skip to content

存在しない郵便番号jsの読み込みを削除 - #1414

Merged
nanasess merged 4 commits into
EC-CUBE:masterfrom
tao-s:fix-wrong-postalcode-js-lib
Aug 4, 2026
Merged

存在しない郵便番号jsの読み込みを削除#1414
nanasess merged 4 commits into
EC-CUBE:masterfrom
tao-s:fix-wrong-postalcode-js-lib

Conversation

@tao-s

@tao-s tao-s commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

おそらくtypo

Summary by CodeRabbit

  • 変更
    • 郵便番号入力補助に関連する不要な外部・ローカルスクリプトの読み込みを削除しました。

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6ced2326-bc21-4757-934c-4ce10fc0eb71

📥 Commits

Reviewing files that changed from the base of the PR and between 2b12183 and 8b96205.

📒 Files selected for processing (1)
  • data/Smarty/templates/default/site_frame.tpl
💤 Files with no reviewable changes (1)
  • data/Smarty/templates/default/site_frame.tpl

📝 Walkthrough

Walkthrough

site_frame.tplから、Ajaxzip3の外部スクリプトとローカルスクリプトの読み込みを削除。

Changes

Ajaxzip3 JS参照の変更

Layer / File(s) Summary
Ajaxzip3読み込みの削除
data/Smarty/templates/default/site_frame.tpl
Ajaxzip3の外部URLとローカルスクリプトの読み込みを削除。

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

🐇 うさぎがテンプレートを確認
Ajaxzip3の読み込みを削除
外部URLもローカルパスも消える
残る画面は静かに動く
ぴょんとレビュー完了!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed タイトルは、存在しない郵便番号JavaScriptの読み込み削除という主な変更を正確かつ簡潔に示しています。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

seasoftjapan
seasoftjapan previously approved these changes Jul 4, 2026
@@ -74,7 +74,6 @@
<!--{/strip}-->

<script type="text/javascript" src="https://ajaxzip3.github.io/ajaxzip3.js"></script>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これも利用されていない

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tao-s これも削除しましょうかね

@seasoftjapan seasoftjapan Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ajaxzip3 で grep しましたが、利用は無さそうですね。

@tao-s @nanasess これで良いでしょうか?
8b96205

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seasoftjapan ありがとうございます!問題なさそうです

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.23%. Comparing base (f56c50a) to head (8b96205).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1414   +/-   ##
=======================================
  Coverage   56.23%   56.23%           
=======================================
  Files          87       87           
  Lines       11091    11091           
=======================================
  Hits         6237     6237           
  Misses       4854     4854           
Flag Coverage Δ
tests 56.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@seasoftjapan
seasoftjapan dismissed their stale review July 31, 2026 10:06

私自身が、コード編集を加えたため、関係者による確認が済むまで一旦 Approved を取り下げます。

@nanasess
nanasess enabled auto-merge July 31, 2026 11:18

@nanasess nanasess left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanasess
nanasess merged commit e3a83ce into EC-CUBE:master Aug 4, 2026
698 of 704 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants