Optimize Docker entrypoint preinitialization time#469
Open
srstsavage wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR speeds up Docker container startup by reducing filesystem ownership changes during entrypoint preinitialization, adds an opt-out for chowning /erddapData, and reports total preinit duration.
Changes:
- Limit
chownscope under${CATALINA_HOME}instead of recursively chowning everything. - Add
SKIP_ERDDAP_DATA_CHOWNto optionally skip chowning/erddapData. - Time and log total preinitialization duration in milliseconds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
srstsavage
force-pushed
the
faster-docker-startup
branch
from
5e02b81 to
a0da0d9
Compare
Avoid chowning ERDDAP classes and dependency jars during container start up to speed up launch time. Also add an environment variable SKIP_ERDDAP_DATA_CHOWN to optionally avoid chowing the (potentially large) /erddapData directory. Also time the preinitialization steps and output the total time taken in milliseconds. Credit @ItaloBorrelli for investigation and optimization suggestions ERDDAP#465
srstsavage
force-pushed
the
faster-docker-startup
branch
from
a0da0d9 to
786f78f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid chowning ERDDAP classes and dependency jars during container start up to speed up launch time. Also add an environment variable SKIP_ERDDAP_DATA_CHOWN to optionally avoid chowing the (potentially large) /erddapData directory. Also time the preinitialization steps and output the total time taken in milliseconds.
Credit @ItaloBorrelli for investigation and optimization suggestions
#465