Skip to content

Gracefully handle the case of missing facets required by esmvalcore.io.local.LocalDataSource#3021

Open
bouweandela wants to merge 8 commits intomainfrom
relax-local-data-source-facet-requirement
Open

Gracefully handle the case of missing facets required by esmvalcore.io.local.LocalDataSource#3021
bouweandela wants to merge 8 commits intomainfrom
relax-local-data-source-facet-requirement

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Mar 19, 2026

Description

Do not raise an exception if a facet required by esmvalcore.io.local.LocalDataSource is missing, but log the problem and continue. Maybe the data can be found using some other data source and if not, the user will see the log message.

Closes #2995

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the enhancement New feature or request label Mar 19, 2026
@bouweandela bouweandela changed the title Gracefully handle the case of missing facets required by esmvalcore.io.local.LocalDataSource Gracefully handle the case of missing facets required by esmvalcore.io.local.LocalDataSource Mar 19, 2026
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.70%. Comparing base (69f2019) to head (c4b0316).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3021   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files         267      267           
  Lines       15768    15793   +25     
=======================================
+ Hits        15090    15115   +25     
  Misses        678      678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela marked this pull request as ready for review March 19, 2026 08:29
@bouweandela bouweandela requested a review from schlunma March 19, 2026 08:29
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks Bouwe! Works exactly as expected.

I just have some minor comments on the code.

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks Bouwe 🚀

@bouweandela
Copy link
Member Author

Thanks for pushing this across the finish line @schlunma!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All facets for all configured data sources of a project are always required

2 participants