Gracefully handle the case of missing facets required by esmvalcore.io.local.LocalDataSource#3021
Open
bouweandela wants to merge 8 commits intomainfrom
Open
Gracefully handle the case of missing facets required by esmvalcore.io.local.LocalDataSource#3021bouweandela wants to merge 8 commits intomainfrom
esmvalcore.io.local.LocalDataSource#3021bouweandela wants to merge 8 commits intomainfrom
Conversation
esmvalcore.io.local.LocalDataSourceesmvalcore.io.local.LocalDataSource
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3021 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 267 267
Lines 15768 15793 +25
=======================================
+ Hits 15090 15115 +25
Misses 678 678 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
schlunma
reviewed
Mar 19, 2026
Contributor
schlunma
left a comment
There was a problem hiding this comment.
Great, thanks Bouwe! Works exactly as expected.
I just have some minor comments on the code.
schlunma
requested changes
Mar 20, 2026
schlunma
reviewed
Mar 23, 2026
schlunma
reviewed
Mar 23, 2026
schlunma
approved these changes
Mar 23, 2026
Contributor
schlunma
left a comment
There was a problem hiding this comment.
Looks good now, thanks Bouwe 🚀
Member
Author
|
Thanks for pushing this across the finish line @schlunma! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not raise an exception if a facet required by
esmvalcore.io.local.LocalDataSourceis missing, but log the problem and continue. Maybe the data can be found using some other data source and if not, the user will see the log message.Closes #2995
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: