Skip to content

fix:incorrect operator precedence #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IshaanXCoder wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix:incorrect operator precedence #484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/codeGenerators/orchestration/nodejs/toOrchestration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,10 @@ export default function codeGenerator(node: any, options: any = {}): any {
}
if (node.expression.operator === '-='){
increments = codeGenerator(node.expression.rightHandSide);
return `\n${privateStateName}_newCommitmentValue = generalise(parseInt(${privateStateName}_newCommitmentValue.integer, 10) + (${increments}));\n`;
const incrementsWithParens = node.expression.rightHandSide.nodeType === 'BinaryOperation'
? `(${increments})`
: increments;
return `\n${privateStateName}_newCommitmentValue = generalise(parseInt(${privateStateName}_newCommitmentValue.integer, 10) - (${incrementsWithParens}));\n`;
}
if (node.expression.operator === '='){
increments = codeGenerator(node.expression.rightHandSide);
Expand Down Expand Up @@ -163,22 +166,30 @@ export default function codeGenerator(node: any, options: any = {}): any {
// To ensure the left hand side is always a general number, we generalise it here (excluding the initialisation in a for loop).
if (!node.isInitializationAssignment && node.rightHandSide.subType !== 'generalNumber'){
if (['+=', '-=', '*='].includes(node.operator)) {
const rightHandSideCode = codeGenerator(node.rightHandSide);
const rightHandSideWithParens = node.rightHandSide.nodeType === 'BinaryOperation'
? `(${rightHandSideCode})`
: rightHandSideCode;
return `${codeGenerator(node.leftHandSide, {
lhs: true,
})} = generalise(${codeGenerator(node.leftHandSide)} ${node.operator.charAt(
0,
)} ${codeGenerator(node.rightHandSide)})`;
)} ${rightHandSideWithParens})`;
}
return `${codeGenerator(node.leftHandSide, { lhs: true })} ${
node.operator
} generalise(${codeGenerator(node.rightHandSide)})`;
} else {
if (['+=', '-=', '*='].includes(node.operator)) {
const rightHandSideCode = codeGenerator(node.rightHandSide);
const rightHandSideWithParens = node.rightHandSide.nodeType === 'BinaryOperation'
? `(${rightHandSideCode})`
: rightHandSideCode;
return `${codeGenerator(node.leftHandSide, {
lhs: true,
})} = ${codeGenerator(node.leftHandSide)} ${node.operator.charAt(
0,
)} ${codeGenerator(node.rightHandSide)}`;
)} ${rightHandSideWithParens}`;
}
return `${codeGenerator(node.leftHandSide, { lhs: true })} ${
node.operator
Expand Down