Skip to content

Remove SideShift privateKey from env config #6024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j0ntz wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −2
Open

Remove SideShift privateKey from env config #6024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- added: Logbox disable option to env.json
- added: Reverse-resolve recipient addresses to ENS / Unstoppable Domains / ZNS names in the send flow, address modal, and transaction history.
- removed: SideShift `privateKey` from env config; the swap integration no longer sends the affiliate secret header.

## 4.49.0 (staging)

Expand Down
3 changes: 1 addition & 2 deletions src/envConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,8 +385,7 @@ export const asEnvConfig = asObject({
SEPOLIA_INIT: asCorePluginInit(asEvmApiKeys),
SIDESHIFT_INIT: asCorePluginInit(
asObject({
affiliateId: asOptional(asString, ''),
privateKey: asOptional(asString)
affiliateId: asOptional(asString, '')
}).withRest
),
SOLANA_INIT: asCorePluginInit(
Expand Down
Loading