Skip to content

Route maestro builds to dedicated Zealot channels #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peachbits wants to merge 1 commit into
base: develop
Choose a base branch
from
+15 −8
Open

Route maestro builds to dedicated Zealot channels #6041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions scripts/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ interface BuildConfigFile {
zealotUrl?: string
zealotApiToken?: string
zealotChannelKey?: string
zealotMaestroChannelKey?: string
hockeyAppId: string
hockeyAppTags: string
hockeyAppToken: string
Expand Down Expand Up @@ -521,7 +522,13 @@ function buildAndroid(buildObj: BuildObj): void {
}

function buildCommonPost(buildObj: BuildObj): void {
const { maestroBuild, zealotApiToken, zealotChannelKey, zealotUrl } = buildObj
const {
maestroBuild,
zealotApiToken,
zealotChannelKey,
zealotMaestroChannelKey,
zealotUrl
} = buildObj
let curl
const notes = `${buildObj.productName} ${buildObj.version} (${buildObj.buildNum}) branch: ${buildObj.repoBranch} #${buildObj.guiHash}`

Expand Down Expand Up @@ -557,12 +564,12 @@ function buildCommonPost(buildObj: BuildObj): void {
mylog('\nUploaded to HockeyApp')
}

if (
zealotApiToken != null &&
zealotUrl != null &&
zealotChannelKey != null &&
!maestroBuild
) {
// Maestro test builds upload to their own channel so they do not pollute the
// production channel's release list. Production builds use zealotChannelKey.
// A maestro build with no zealotMaestroChannelKey configured skips Zealot.
const channelKey = maestroBuild ? zealotMaestroChannelKey : zealotChannelKey

if (zealotApiToken != null && zealotUrl != null && channelKey != null) {
const branch = encodeURIComponent(buildObj.repoBranch)
const gitCommit = encodeURIComponent(buildObj.guiHash)
chdir(buildObj.guiDir)
Expand All @@ -576,7 +583,7 @@ function buildCommonPost(buildObj: BuildObj): void {
)

call(
`curl -X POST "${zealotUrl}/api/apps/upload?token=${zealotApiToken}&channel_key=${zealotChannelKey}&branch=${branch}&git_commit=${gitCommit}&changelog=${changelog}" -F "file=@${buildObj.ipaFile}"`
`curl -X POST "${zealotUrl}/api/apps/upload?token=${zealotApiToken}&channel_key=${channelKey}&branch=${branch}&git_commit=${gitCommit}&changelog=${changelog}" -F "file=@${buildObj.ipaFile}"`
)
mylog('\n*** Upload to Zealot Complete ***')
}
Expand Down
Loading