Skip to content

Update Monero wallet settings menu#6045

Open
j0ntz wants to merge 3 commits into
developfrom
jon/update-monero-wallet-menu
Open

Update Monero wallet settings menu#6045
j0ntz wants to merge 3 commits into
developfrom
jon/update-monero-wallet-menu

Conversation

@j0ntz

@j0ntz j0ntz commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Description

Asana task

Reorganizes the wallet list overflow menu and the Wallet Settings modal so asset-wide settings are reached through Wallet Settings instead of a separate top-level entry.

Changes:

  • Remove the top-level "Asset Settings" item from the wallet list menu.
  • Move the settings gear icon onto "Wallet Settings" (it previously sat on "Asset Settings").
  • Rename the Monero backend card header from "Backend" to "Server Settings".
  • Rename the Monero custom-server navigation row from "Configure Custom" to "Asset Settings" (reusing the existing string).
  • For non-Monero wallets, the Wallet Settings modal now shows the wallet rename field plus an "Asset Settings" + chevron row inside a card, so asset settings stay reachable. The card is scoped to the wallet list flow and does not change the create-wallet flow.

Testing (iOS simulator, edge-funds account):

  • Monero wallet: the menu no longer lists "Asset Settings" and "Wallet Settings" shows the gear icon; opening it shows the "Server Settings" header with LWS / Full Node radios and an "Asset Settings" chevron row.
  • Bitcoin (non-Monero) wallet: opening "Wallet Settings" shows the rename field and an "Asset Settings" chevron card, which navigates to the asset settings scene.
  • tsc, eslint, and jest all pass.

Note

Low Risk
Navigation and copy changes only; asset settings remain reachable and Monero duplicates are guarded by showAssetSettingsCard logic.

Overview
Wallet list overflow menu no longer includes a top-level Asset Settings entry. The settings gear icon is now on Wallet Settings (control-panel-settings), and menu rows get testID values for testing.

Wallet Settings modal adds an Asset Settings chevron card for plugins that support asset settings but do not already navigate to currencySettings in their own wallet-settings card (e.g. Bitcoin). Monero keeps a single path via its embedded card.

Monero wallet settings rename the backend card header from Backend to Server Settings and the custom-server row label from Configure Custom to Asset Settings (reusing the existing string). Unused locale keys are removed.

Reviewed by Cursor Bugbot for commit abc5a5f. Bugbot is set up for automated code reviews on this repo. Configure here.

j0ntz added 3 commits June 19, 2026 15:22
Move Asset Settings access into the Wallet Settings modal instead of a
separate top-level menu item, give Wallet Settings the settings gear icon,
rename the Monero backend card to Server Settings, and surface an Asset
Settings chevron row for non-Monero wallets.
@j0ntz

j0ntz commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence (iOS sim)

agent proof 1215849737061906 01 monero menu no asset settings

agent proof 1215849737061906 01 monero menu no asset settings

agent proof 1215849737061906 02 monero server settings

agent proof 1215849737061906 02 monero server settings

agent proof 1215849737061906 03 nonmonero btc asset settings

agent proof 1215849737061906 03 nonmonero btc asset settings

Captured by the agent's in-app test run (build-and-test).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant