Update Monero wallet settings menu#6045
Open
j0ntz wants to merge 3 commits into
Open
Conversation
Move Asset Settings access into the Wallet Settings modal instead of a separate top-level menu item, give Wallet Settings the settings gear icon, rename the Monero backend card to Server Settings, and surface an Asset Settings chevron row for non-Monero wallets.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Asana task
Reorganizes the wallet list overflow menu and the Wallet Settings modal so asset-wide settings are reached through Wallet Settings instead of a separate top-level entry.
Changes:
Testing (iOS simulator, edge-funds account):
Note
Low Risk
Navigation and copy changes only; asset settings remain reachable and Monero duplicates are guarded by
showAssetSettingsCardlogic.Overview
Wallet list overflow menu no longer includes a top-level Asset Settings entry. The settings gear icon is now on Wallet Settings (
control-panel-settings), and menu rows gettestIDvalues for testing.Wallet Settings modal adds an Asset Settings chevron card for plugins that support asset settings but do not already navigate to
currencySettingsin their own wallet-settings card (e.g. Bitcoin). Monero keeps a single path via its embedded card.Monero wallet settings rename the backend card header from Backend to Server Settings and the custom-server row label from Configure Custom to Asset Settings (reusing the existing string). Unused locale keys are removed.
Reviewed by Cursor Bugbot for commit abc5a5f. Bugbot is set up for automated code reviews on this repo. Configure here.