Repository navigation
chore: add ar_SA locale for Arabic - #62
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
7 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ar_SA.UTF-8to thelocale-genlist indev/Dockerfile, alongside the other radio-language locales (same as chore: add sk_SK locale for Slovak custom-function sort generation #53 did for Slovak).Why
EdgeTX/edgetx#8031 adds Arabic (AR) as a radio language.
tools/cfn_sorter.shcompilescfn_sorter.cpponce per locale inRADIO_LANGUAGESto regenerateradio/src/cfn_sort.cpp, and that PR addsLNG_ARusingar_SA.UTF-8. This dev image doesn't generate that locale, so the Codegen drift / cfn-sort check fails on that PR with:Only the dev image needs this. The
builderimage (used by cloudbuild) just compiles the checked-incfn_sort.cppand never runs the sorter, so it doesn't need any locales.Test plan
locale -ain the built image includesar_SA.utf8tools/cfn_sorter.shfrom feat: Arabic (AR) radio translation foundation edgetx#8031 completes without the locale error🤖 Generated with Claude Code