Skip to content

Show currently open workspaces as bold + always show hamburger menu#42

Merged
Elec0 merged 3 commits into
mainfrom
bold-all-open-workspaces
May 1, 2025
Merged

Show currently open workspaces as bold + always show hamburger menu#42
Elec0 merged 3 commits into
mainfrom
bold-all-open-workspaces

Conversation

@Elec0
Copy link
Copy Markdown
Owner

@Elec0 Elec0 commented May 1, 2025

Instead of showing only the current workspace as bold, now it shows all currently open workspaces as bold.
This should allow for easier at-a-glance navigation.

Additionally, the 'Add workspace' and 'Settings' buttons are now available in all instances of the extension popup.

Closes #30 #36

@Elec0 Elec0 added the enhancement New feature or request label May 1, 2025
@Elec0 Elec0 requested a review from Copilot May 1, 2025 19:34
@Elec0 Elec0 self-assigned this May 1, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the workspace display logic by showing all open workspaces as bold and ensures that the 'Add workspace' and 'Settings' buttons are always available in the extension popup.

  • Updated WorkspaceEntryLogic.listWorkspaces to use an array of window IDs for determining open workspaces.
  • Introduced a new utility method in Utils to retrieve all Chrome window IDs.
  • Refactored Popup and PopupActions to align with the new workspace determination logic.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/workspace-entry-logic.ts Modified listWorkspaces to add the 'workspace-open' class if the workspace’s window is open.
src/utils.ts Added getAllWindowIds to fetch an array of all Chrome window IDs.
src/popup.js Updated popup initialization to supply window IDs, and removed obsolete workspace checks.
src/popup-actions.ts Updated workspace action handlers to refresh the workspace list using all window IDs.
Files not reviewed (1)
  • src/popup.css: Language not supported
Comments suppressed due to low confidence (1)

src/popup.js:5

  • [nitpick] If the removed event listeners and commented code are no longer needed, consider cleaning them up to reduce clutter and improve maintainability.
chrome.tabs.onRemoved.addListener(WorkspaceEntryLogic.tabRemoved);

Comment thread src/workspace-entry-logic.ts Outdated
Elec0 and others added 2 commits May 1, 2025 12:38
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Elec0 Elec0 merged commit d26ffc2 into main May 1, 2025
1 check passed
@Elec0 Elec0 deleted the bold-all-open-workspaces branch May 1, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display open workspaces differently in all windows

2 participants