Show currently open workspaces as bold + always show hamburger menu#42
Merged
Conversation
…pdate CSS class for current workspace
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the workspace display logic by showing all open workspaces as bold and ensures that the 'Add workspace' and 'Settings' buttons are always available in the extension popup.
- Updated WorkspaceEntryLogic.listWorkspaces to use an array of window IDs for determining open workspaces.
- Introduced a new utility method in Utils to retrieve all Chrome window IDs.
- Refactored Popup and PopupActions to align with the new workspace determination logic.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/workspace-entry-logic.ts | Modified listWorkspaces to add the 'workspace-open' class if the workspace’s window is open. |
| src/utils.ts | Added getAllWindowIds to fetch an array of all Chrome window IDs. |
| src/popup.js | Updated popup initialization to supply window IDs, and removed obsolete workspace checks. |
| src/popup-actions.ts | Updated workspace action handlers to refresh the workspace list using all window IDs. |
Files not reviewed (1)
- src/popup.css: Language not supported
Comments suppressed due to low confidence (1)
src/popup.js:5
- [nitpick] If the removed event listeners and commented code are no longer needed, consider cleaning them up to reduce clutter and improve maintainability.
chrome.tabs.onRemoved.addListener(WorkspaceEntryLogic.tabRemoved);
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of showing only the current workspace as bold, now it shows all currently open workspaces as bold.
This should allow for easier at-a-glance navigation.
Additionally, the 'Add workspace' and 'Settings' buttons are now available in all instances of the extension popup.
Closes #30 #36