Fix PopupActions calling StorageHelper directly instead of via background messaging#50
Merged
Merged
Conversation
… in PopupActions Agent-Logs-Url: https://github.com/Elec0/chrome-edge-workspaces/sessions/508b4e84-0a76-4fc2-ae75-2fb7a9cd8af5 Co-authored-by: Elec0 <5119098+Elec0@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix PopupActions using StorageHelper in front end
Fix PopupActions calling StorageHelper directly instead of via background messaging
May 8, 2026
Elec0
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StorageHelperis intended to be background-script-only, butPopupActions.deleteWorkspace,renameWorkspace, andclearWorkspaceDatawere callingStorageHelper.getWorkspaces()directly from the popup context after their respective operations.Changes
popup-actions.ts: Replace directStorageHelper.getWorkspaces()calls withgetWorkspaceStorage()indeleteWorkspace,renameWorkspace, andclearWorkspaceDatagetWorkspaceStorage()(frompopup.js) fetches workspaces from the background script viachrome.runtime.sendMessage, which is the correct pattern already used byopenWorkspaceandhandleNewWorkspaceResponse.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
edgedl.me.gvt1.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.mjs(dns block)If you need me to access, download, or install something from one of these locations, you can either: