Skip to content

Fix PopupActions calling StorageHelper directly instead of via background messaging#50

Merged
Elec0 merged 2 commits into
mainfrom
copilot/fix-popupactions-using-storagehelper
May 8, 2026
Merged

Fix PopupActions calling StorageHelper directly instead of via background messaging#50
Elec0 merged 2 commits into
mainfrom
copilot/fix-popupactions-using-storagehelper

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

StorageHelper is intended to be background-script-only, but PopupActions.deleteWorkspace, renameWorkspace, and clearWorkspaceData were calling StorageHelper.getWorkspaces() directly from the popup context after their respective operations.

Changes

  • popup-actions.ts: Replace direct StorageHelper.getWorkspaces() calls with getWorkspaceStorage() in deleteWorkspace, renameWorkspace, and clearWorkspaceData

getWorkspaceStorage() (from popup.js) fetches workspaces from the background script via chrome.runtime.sendMessage, which is the correct pattern already used by openWorkspace and handleNewWorkspaceResponse.

// Before
WorkspaceEntryLogic.listWorkspaces(await StorageHelper.getWorkspaces(), await Utils.getAllWindowIds());

// After
WorkspaceEntryLogic.listWorkspaces(await getWorkspaceStorage(), await Utils.getAllWindowIds());

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • edgedl.me.gvt1.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.mjs (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue May 8, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix PopupActions using StorageHelper in front end Fix PopupActions calling StorageHelper directly instead of via background messaging May 8, 2026
Copilot finished work on behalf of Elec0 May 8, 2026 00:13
Copilot AI requested a review from Elec0 May 8, 2026 00:13
@Elec0 Elec0 marked this pull request as ready for review May 8, 2026 01:07
@Elec0 Elec0 merged commit 7858929 into main May 8, 2026
1 check passed
@Elec0 Elec0 deleted the copilot/fix-popupactions-using-storagehelper branch May 8, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PopupActions uses StorageHelper from the front end

2 participants