Skip to content

Fix docker version in the Docker image #8659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2025
Merged

Fix docker version in the Docker image #8659

merged 1 commit into from
Nov 13, 2025
+18 −5

Conversation

@ShahanaFarooqui
Copy link
Collaborator

@ShahanaFarooqui ShahanaFarooqui commented Nov 4, 2025

Changelog-Fixed: Core lightning version in Docker image will not be missing.

Fixes #8602.

@ShahanaFarooqui ShahanaFarooqui marked this pull request as ready for review November 4, 2025 06:51
@ShahanaFarooqui
Copy link
Collaborator Author

ShahanaFarooqui commented Nov 4, 2025

The version string includes the -modded suffix even on tagged commits due to changes detected by git status:

Changes not staged for commit:
  - deleted: Dockerfile
  - deleted: contrib/docker/Dockerfile.builder.fedora

Untracked files:
  - .cargo/

To fix this, we added these paths to .dockerignore & .gitignore.

@ShahanaFarooqui ShahanaFarooqui mentioned this pull request Nov 4, 2025
Closed
@ShahanaFarooqui ShahanaFarooqui added this to the v25.12 milestone Nov 6, 2025
@madelinevibes madelinevibes added the Status::Ready for Review The work has been completed and is now awaiting evaluation or approval. label Nov 12, 2025
sangbida
sangbida approved these changes Nov 13, 2025
View reviewed changes
Copy link
Collaborator

@sangbida sangbida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just need to fix the merge conflict.

@ShahanaFarooqui
docker: Fix missing CLN version in docker image
aef0ce6 
Changelog-Fixed: Core lightning version in Docker image will not be missing.
@sangbida sangbida enabled auto-merge (rebase) November 13, 2025 01:33
@sangbida sangbida disabled auto-merge November 13, 2025 01:34
@sangbida sangbida merged commit 5733046 into ElementsProject:master Nov 13, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sangbida sangbida sangbida approved these changes

Assignees

No one assigned

Labels

Status::Ready for Review The work has been completed and is now awaiting evaluation or approval.

Projects

None yet

Milestone

v25.12

Development

Successfully merging this pull request may close these issues.

Docker Image Built via Manual Workflow Does Not Reflect Correct Core Lightning Version

3 participants

@ShahanaFarooqui @sangbida @madelinevibes