ccan: Update vendored ccan to commit fe99a8e0, which includes rustyrussell/ccan#129#9278
Open
nGoline wants to merge 1 commit into
Open
ccan: Update vendored ccan to commit fe99a8e0, which includes rustyrussell/ccan#129#9278nGoline wants to merge 1 commit into
nGoline wants to merge 1 commit into
Conversation
Includes rustyrussell/ccan#129, which replaces asort's old quicksort fallback with glibc 2.43's mergesort+heapsort. The old fallback called cmp(pivot, pivot) on all-equal arrays, violating the comparator contract that pointer identity implies distinct elements. Mergesort never self-compares, matching qsort_r behaviour on systems without it. This unblocks removing the temporary self-comparison guard in cmp_rr_number(). Changelog-None
nGoline
added
the
Status::Ready for Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the vendored
ccan/tree fromefd48386tofe99a8e0.The headline change is rustyrussell/ccan#129, which replaces
asort's old glibc-2004 quicksort fallback with glibc 2.43's stable mergesort (heapsort fallback). The old quicksort calledcmp(pivot, pivot)when sorting all-equal arrays, violating the comparator contract that pointer identity implies distinct elements. Mergesort never self-compares, so it now matchesqsort_rbehaviour on platforms that lack it (e.g. macOS).The resync also pulls in a cosmetic row-numbering reformat of
base64.c(rustyrussell/ccan commit 11024115).This unblocks #9153: once merged, the temporary self-comparison guard in
cmp_rr_number()can be dropped.Changelog-None