Repository navigation
Conversation
Lagrang3
force-pushed
the
fix-unverified-dual-funding-tx-signatures
branch
from
September 25, 2026 11:12
2341c8f to
ab73b9e
Compare
nGoline
requested changes
Oct 28, 2026
nGoline
left a comment
nGoline
left a comment
Collaborator
There was a problem hiding this comment.
The direction looks right, and the new checks do not reject the common honest witnesses (P2WPKH, P2TR key path, P2WSH multisig). A few inline things before merge.
Also, on channeld/channeld.c:2959: splice tx_signatures do not get these checks. A follow-up is fine, but a FIXME or a note in the PR description would help keep the two paths in sync.
Lagrang3
force-pushed
the
fix-unverified-dual-funding-tx-signatures
branch
from
October 30, 2026 10:15
ab73b9e to
8052eeb
Compare
Adding minimal verification of tx_signatures to get closer to the specification on dual funded channels and splice. We check that the witnesses are not empty and do a minimal standardness policy check. The sighash flag must be set to SIGHASH_ALL. Changelog-Fixed: dualopen and splicing: added tx_signatures verification according to BOLT-2 Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
fix-unverified-dual-funding-tx-signatures
branch
from
October 30, 2026 10:20
8052eeb to
0ae3407
Compare
Collaborator
Author
I have used the same helpers for splice as well. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding minimal verification of tx_signatures to get closer to the
specification on dual funded channels.
We check that the witnesses are not empty and do a minimal standardness
policy check. Still missing a SIGHASH_ALL byte verification.