add recursive symmetry checks + check for existing attr #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav-arya
force-pushed
the
symmetry
branch
from
9d4bf3e to
357e961
Compare
gaurav-arya
changed the title
gaurav-arya
changed the title
gaurav-arya
changed the title
gaurav-arya
force-pushed
the
symmetry
branch
2 times, most recently
from
ae0cae7 to
1345bac
Compare
gaurav-arya
changed the title
gaurav-arya
force-pushed
the
symmetry
branch
from
05720e3 to
83e2944
Compare
avik-pal
reviewed
Nov 17, 2025
gaurav-arya
force-pushed
the
symmetry
branch
from
83e2944 to
721b7c8
Compare
gaurav-arya
force-pushed
the
symmetry
branch
from
721b7c8 to
573167a
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
EnzymeJAX Benchmarks
| Benchmark suite | Current: 173903f | Previous: b55ffd4 | Ratio |
|---|---|---|---|
scatter_sum / JaX / cpu / Primal |
0.00000438585311640054 s |
0.000004338932399696205 s |
1.01 |
scatter_sum / JaXPipe / cpu / Primal |
0.000004262724006548524 s |
0.000004298453299998073 s |
0.99 |
scatter_sum / JaX / tpu / Primal |
0.0001382552735041 s |
0.0001558048111997 s |
0.89 |
scatter_sum / JaXPipe / tpu / Primal |
0.0001349988545058 s |
0.0001522772955002 s |
0.89 |
This comment was automatically generated by workflow using github-action-benchmark.
avik-pal
reviewed
Nov 17, 2025
src/enzyme_ad/jax/Utils.cpp
Outdated
Comment on lines
663
to
665
| if (isa<enzymexla::SymmOp>(op)) { | ||
| return State::GUARANTEED; | ||
| } |
Collaborator
There was a problem hiding this comment.
Is this generally true? it is true for syrk but not for symm if B is not symmetric
Member
Author
There was a problem hiding this comment.
yup you're right, there's no op for syrk yet right?
avik-pal
reviewed
Nov 17, 2025
src/enzyme_ad/jax/Utils.cpp
Outdated
| recursiveCheck = true; | ||
| } | ||
|
|
||
| if (isa<stablehlo::TransposeOp>(op), isa<stablehlo::DotGeneralOp>(op)) { |
Collaborator
There was a problem hiding this comment.
for dot general it only holds if the operands commute, not in general I think
Member
There was a problem hiding this comment.
even then not necessarily since you could have batched dimensions
gaurav-arya
changed the title
gaurav-arya
changed the title
Member
Author
|
Okay I just got rid of the wrong checks |
gaurav-arya
changed the title
gaurav-arya
changed the title
avik-pal
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.