lore-server: Support file:// JWKS endpoints in JWK service #44
Open
kidskoding wants to merge 2 commits into
Open
lore-server: Support file:// JWKS endpoints in JWK service #44kidskoding wants to merge 2 commits into
kidskoding wants to merge 2 commits into
Conversation
Author
|
maintainers / someone please review - @ragnarula @mjansson |
mjansson
reviewed
Jun 22, 2026
Author
|
sure thing! accidentally stashed all changes at once! |
added 2 commits
June 22, 2026 03:58
Signed-off-by: Anirudh Konidala <kidskodingclub@gmail.com>
Per review feedback, the file:// and http(s):// JWKS load paths shared one generic parse-error warning. Split it so the file case logs "invalid JWKS file contents" and the remote case keeps "failed to parse JWKS response". Signed-off-by: Anirudh Konidala <kidskodingclub@gmail.com>
Author
|
@peter-lockhart-pub please review again, along with #50! |
Author
|
Maintainers may need to reapprove CI/CD workflows due to a force push of commits on existing fork, intended to align with relevant PR titles - @mjansson, @peter-lockhart-pub |
Collaborator
Done! This PR will be picked up by another process that will merge it now that it is approved and good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #32
Added a scheme check in
fetch_new_keys()that checks for either file:// or http:// (https://)tokio::fs::read_to_stringinstead of communicating over HTTP)Test Plan
Added two tests covering the new file-read path: one verifies keys load correctly from a file:// endpoint and the other confirms a missing file still fails cleanly