Repository navigation
Conversation
os.path.normpath performs purely lexical normalization, which fails when
parent directory traversals ('..') follow a symbolic link. Use a
filesystem-aware resolver to locate source files correctly when symlinks
and relative traversals are combined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3645.
When source files are included or located via paths that traverse backwards (
..) through a symbolic link directory, purely lexical normalization (os.path.normpath) incorrectly strips the directory name rather than stepping back from the physical symlink target. This leads to broken paths, causing CodeChecker to report missing/changed source files and miss defects duringparse.Solution
resolve_path()helper function incodechecker_report_converter.util.os.path.normpathwithresolve_pathincodechecker_report_converter.report.parser.plist.get_file_index_map.tools/report-converter/tests/unit/util/test_resolve_path.pycovering:..).