Repository navigation
[gui] Fix git blame not showing on the first line - #5143
Open
barnabasdomozi wants to merge 1 commit into
Open
barnabasdomozi wants to merge 1 commit into
barnabasdomozi wants to merge 1 commit into
Conversation
The blame gutter used `!line?.from` to skip empty lines. The first line's offset is 0, so `!0` was true and its blame marker was dropped. Files whose only commit starts on line 1 showed no blame at all. Check `line?.from == null` instead, so offset 0 is treated as valid.
barnabasdomozi
requested review from
bruntib and
gulyasgergely902
as code owners
October 7, 2026 14:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blame gutter used
!line?.fromto skip empty lines. The first line's offset is 0, so!0was true and its blame marker was dropped. Files whose only commit starts on line 1 showed no blame at all.Check
line?.from == nullinstead, so offset 0 is treated as valid.