Repository navigation
refactor: move parse and related function to common - #337
Conversation
|
CI fails on unchanged files. Since we plan on removing test/common after merging all pytest-to-Bazel PRs ( |
1266984 to
82816f1
Compare
Szelethus
left a comment
There was a problem hiding this comment.
I figured a primary motivation behind this patch was unifying per_file and monolithic runs, but I see that you don't call parse at all from per_file. Is this intentional?
|
The primary motivation in this PR was to split the #315 patch into two. |
82816f1 to
e869f1d
Compare
This is to reuse these functions from the per_file script.0
7f4305c to
060baef
Compare
…s, add execution mode to per-file
Szelethus
left a comment
There was a problem hiding this comment.
LGTM; I'm sure we'll catch something that could've been moved here, but at that point we are making our life harder for no gain. We want this patch, so lets not delay it any longer.
Why:
We want to have feature and behaviour parity between the monolithic and the per-file rule. To achieve this, we want these modules to share code where it's possible.
Related: #315
What:
Addresses:
none
Depends on: #342