Make Optional annotation repeatable#1253
Merged
theigl merged 2 commits intoEsotericSoftware:masterfrom Jan 29, 2026
Merged
Conversation
680bda7 to
ee2727d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Optional annotation is not repeatable. This pull request makes it repeatable with or-semantics. That is, if multiple Optional annotations exist for the same field, then the field is serialized if and only if at least one of the specified keys is in the kryo context.
This enables use cases where more than two serialization configurations are needed where we can use the Optional annotation without the necessity to use a FieldSerializer.