test: Sprint test-2 — server logic + armo_base_panel anual#65
Merged
test: Sprint test-2 — server logic + armo_base_panel anual#65
Conversation
Cobertura de la capa server-side: - mod_calidad_panel_server (testServer): 9 tests para los reactives expuestos por el módulo. Switch del dataset según tipo_duo (trim ↔ anual), filtrado por rango de años y dúos, outputs KPI calculando promedios sobre el filtro activo. Mock de globals (df_calidad_panel + df_calidad_panel_anual) y stub global de renderHighchart para no exigir el paquete en CI. - armo_base_panel(window = "anual") (sin testServer): 6 tests con un parquet sintético en with_tempdir(). Verifica filter pushdown sobre (anio_0, trim_0), drop de esas cols del output, error informativo si no existe el parquet, validación de window inválido. Cubre el hotfix v0.7.3 (open_dataset vs read_parquet) sin tocar el archivo de producción. mod_analisis_*_server diferidos a Sprint test-3 (E2E con shinytest2): requieren mockear ~6 globals por módulo y el ROI es bajo vs probar el flujo real desde browser. Suite completa: 185 tests PASS · 0 fail. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mod_analisis_*_server (cond_act / cat_ocup / formalidad) se difieren a Sprint test-3: requieren mockear ~6 globales por módulo y el ROI es bajo vs cubrirlo con shinytest2 E2E.
Suite local: 185 tests PASS (149 → 185).
Test plan
Rscript tests/testthat.R→ 185 PASS).tests-unit.yml) verde con shiny + bslib ya en la lista de paquetes mínimos.🤖 Generated with Claude Code