Repository navigation
Sepolia v6: addresses, margin ABI, marginSwap223 minimum output - #427
Merged
Merged
Conversation
test-app moves to the Sepolia v6 deployment of 2026-11-07: factory, router, position manager, both autolistings, margin module, oracle, fee collector and the pool init code hash 0x5944…. The margin ABI is regenerated from the v6 build: marginSwap223 takes the owner's minimum output (contracts #198), so the ERC-223 swap now passes minimumAmountOut; isOrderOpen and predictTokenListsID are gone (no callers); lender-protection functions from #182 are added.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test-app ran on Sepolia v4. The v6 deployment of 2026-11-07 carries everything merged through Dex223-contracts #200, and its margin module changes the ABI:
marginSwap223takes the owner's minimum output (#198).Change
sdk_bi/addresses.ts, Sepolia: factory0xbdC7…1A86, router0x6812…E71b, position manager0x461A…A4D0, core and free autolistings, margin module0x0586…1D18, oracle0x4859…4354, fee collector0x44f9…5C90, pool init code hash0x594484e1…ac60(Dex223-contractsdeployments/sepolia-v6.json).config/abis/marginModule.tsregenerated from the v6 build.isOrderOpenandpredictTokenListsIDare gone (no callers);orderSetLenderProtection,orderMaintenanceMarginBps,orderLiquidationKeeperandpositionUnderwaterSinceare added.useMarginSwap.ts: the ERC-223 path passesminimumAmountOuttomarginSwap223, so the "minimum received" shown to the user is now enforced on-chain (MM21 below it). Test updated.Verification
tests/marginSwap.test.cjs6 passing,apiProxies13,swapReceipt20. ESLint clean on the changed files;tscshows only the pre-existing trading-chart errors from the local node_modules.Open
dex-223-v-1-sepoliaanddex-223-margin-sepoliaversionv6-20261107); the exchange subgraph is still replaying from block 8468334.