feat: add macOS native capture and cursor pipeline#1
Closed
EtienneLescot wants to merge 2 commits into
Closed
Conversation
…-pipeline feat: add Windows native capture and cursor pipeline
a4786a5 to
603e06c
Compare
Owner
Author
|
Closing this duplicate PR because the macOS native capture branch is now opened against the upstream repository: siddharthvaddem#573 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This draft PR starts the macOS-only port of the native capture and cursor pipeline introduced for Windows in PR siddharthvaddem#217.
The goal is to bring the same architectural separation to macOS: Electron owns recording/session orchestration, while a native ScreenCaptureKit helper owns screen/window capture, cursor exclusion, audio/webcam timing, encoding, and muxing.
This PR is currently stacked on
feat/cursor-pipelineso the diff stays focused on macOS. It should be retargeted tomainafter the Windows-native PR lands.What changed
docs/engineering/macos-native-recorder-roadmap.md.src/lib/nativeMacRecording.ts.npm run build:native:macas a placeholder build entrypoint.electron/native/README.md.macOS-only scope
This PR does not change Windows native capture behavior and does not add Linux native capture.
The macOS helper implementation is not shipped yet. This first step is the architecture/contract scaffold so the native helper can be added behind a clean boundary, matching the Windows WGC helper separation.
Architecture notes
The intended macOS backend follows the same separation used by the Windows helper and the same broad platform approach seen in Recordly:
Validation run
Passed locally on Windows:
npm run build:native:mac(skips successfully on non-macOS hosts)npm run build-vitenpx vitest run src\lib\nativeMacRecording.test.ts --pool=threadsnpm test(137 tests passing)Maintainer test checklist
Capture + Launch
Audio
Editor Load + Playback
Timeline
Project Persistence
Other