feat(warhead)!: Warhead.RemainingCooldown and WarheadStatus.OnCooldown

[Unbistrackted]

Description

Describe the changes
Add OnCooldown for WarheadStatus, which I implemented it's logic into Warhead.Status + changed the ternary operators to if statements so it's more easy to read

Add Warhead.RemainingCooldown so you don't have to use NetworkTime.time to change the cooldown

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
I forgot to add WarheadStatus.OnCooldown in the last pull request

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentations

Submission checklist

• I have checked the project can be compiled
• I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

• I have checked no IL patching errors in the console

Other

• Still requires more testing

[louis1706]

the Setter will need to be modified

[Unbistrackted]

Thx for pointing that out, forgot abt it

btw I'm using the .HasFlagsFast extension, I remember using it once on one my projects, hope this isn't a problem

[Someone-193]

I dont get this, can the warhead be in multiple states or something? If not, why do we have its enum be flags?

[Unbistrackted]

The warhead can be armed and on cooldown at the same time for example

I think it's better this way, rather than representing a single state

Armed, OnCooldown
Not Armed, OnCooldown,
InProgress, Armed
InProgress, NotArmed

[Someone-193]

as was pointed out to me a while ago by somebody I forgot, the setter for warhead actually doesnt work here because if you do something like Warhead.Status = Warhead.Status after nuke blows up, it'd just retrigger the nuke no? You're going to need to check for changes in each flag between the old and new values I think, at that rate though you might want to start using bitwise operators in your if checks like if ((value ^ IsInProgress)) then do a HasFlagFast check (or another bitwise operation)