Feature/SOF-7781-1 Update: our pyproject setup #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyproject.toml
Outdated
| @@ -1,10 +1,105 @@ | |||
| [project] | |||
| name = "mat3ra-api-client" | |||
Member
There was a problem hiding this comment.
should be in mat3ra.api_client
| host (str): Exabyte API hostname. | ||
| port (int): Exabyte API port number. | ||
| version (str): Exabyte API version. Defaults to 2018-10-1. | ||
| host (str): Mat3ra API hostname. |
Member
There was a problem hiding this comment.
We can just keep API hostname and similarly other
| secure (bool): whether to use secure http protocol (https vs http). Defaults to True. | ||
|
|
||
| Attributes: | ||
| conn (httplib.ExabyteConnection): ExabyteConnection instance. | ||
| conn (httplib.Mat3raConnection): Mat3raConnection instance. |
Member
There was a problem hiding this comment.
Should be just Connection
src/py/mat3ra_api_client/helpers.py
Outdated
| @@ -0,0 +1,215 @@ | |||
| """ | |||
| @@ -0,0 +1,27 @@ | |||
| """ | |||
tests/py/integration/__init__.py
Outdated
| ENV_TEST_ACCOUNT_ID = "TEST_ACCOUNT_ID" | ||
| ENV_TEST_AUTH_TOKEN = "TEST_AUTH_TOKEN" | ||
| ENV_TEST_SECURE = "TEST_SECURE" | ||
| ENV_TEST_VERSION = "TEST_VERSION" |
Member
There was a problem hiding this comment.
Remove the above and use explicitly
VsevolodX
force-pushed
the
feature/SOF-7781-1
branch
from
66ad0e3 to
d9ccf11
Compare
timurbazhirov
approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.