ci(release): stop waiting for TestFlight with an expired token - #538
Merged
Conversation
The upload succeeded and the step failed anyway. `apple-actions/upload-testflight-build@v5` signs one App Store Connect JWT with a 600-second life — `n=600` in its bundled dist/index.js, with no re-signing anywhere in it — and then polls for the build to become visible on a schedule that sleeps 60 + 120 + 240 + 300 = 720 seconds before giving up. The token is guaranteed to die first, so any build Apple takes more than a few minutes to process reports 401 NOT_AUTHORIZED with the binary already delivered. Build 426000342 is on TestFlight; the run is red. The wait is only there so the action can write metadata afterwards, and this step asks for none: it sets neither release-notes nor uses-non-exempt-encryption, and Info.plist already declares ITSAppUsesNonExemptEncryption. What is given up is being told when Apple rejects a binary during processing. That signal was already gone — the step failed on the expired token whether processing passed or not, so the red said nothing about the build either way.
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upload succeeded and the step failed anyway.
apple-actions/upload-testflight-build@v5signs one App Store Connect JWT with a 600-second life —n=600in its bundled dist/index.js, with no re-signing anywhere in it — and then polls for the build to become visible on a schedule that sleeps 60 + 120 + 240 + 300 = 720 seconds before giving up. The token is guaranteed to die first, so any build Apple takes more than a few minutes to process reports 401 NOT_AUTHORIZED with the binary already delivered. Build 426000342 is on TestFlight; the run is red.The wait is only there so the action can write metadata afterwards, and this step asks for none: it sets neither release-notes nor uses-non-exempt-encryption, and Info.plist already declares ITSAppUsesNonExemptEncryption.
What is given up is being told when Apple rejects a binary during processing. That signal was already gone — the step failed on the expired token whether processing passed or not, so the red said nothing about the build either way.
這個 PR 做了什麼
相關 issue
怎麼驗
檢查清單
tool/check/commits.sh origin/main..HEAD通過—— commit 訊息就是更新日誌，格式見 commit.md
mise exec -- flutter analyze與mise exec -- flutter test通過AppLocalizations，沒有寫死AppSpacing/AppRadius/AppMotion，深色模式看過，文字對比度可接受