-
Notifications
You must be signed in to change notification settings - Fork 3.5k
add onboarding checks paying domain user #74941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add onboarding checks paying domain user #74941
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good from a product perspective 👍
…g-checks-paying-domain-user
…g-checks-paying-domain-user
…g-checks-paying-domain-user
…g-checks-paying-domain-user
…g-checks-paying-domain-user
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
@huult, looking good!
I believe in this case it should also say "Your company restricts workspace creation by non-admin users. You can request access to an existing workspace or reach out to an internal admin for more information" instead of "Track receipts, reimburse expenses, manage travel, send invoices, and more." |
|
@eVoloshchak We have two places that use the same text ('Track receipts, reimburse expenses, manage travel, send invoices, and more.'): |

Details
Fixed Issues
$ #63378
PROPOSAL: #63378 (comment)
Tests
Same QA step
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-08-12.at.10.55.38.mp4
Android: mWeb Chrome
Screen.Recording.2025-08-12.at.10.57.02.mp4
iOS: Native
Screen.Recording.2025-08-12.at.10.58.49.mp4
iOS: mWeb Safari
Screen.Recording.2025-08-12.at.10.59.41.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-08-12.at.10.45.37.mp4
MacOS: Desktop
Screen.Recording.2025-08-12.at.10.49.17.mp4