Show the travel card icon for other members' travel expenses#95320
Draft
allgandalf wants to merge 6 commits into
Draft
Show the travel card icon for other members' travel expenses#95320allgandalf wants to merge 6 commits into
allgandalf wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The travel card icon only showed for your own travel expenses.
TypeCellderived it fromisTravelCard(card), andcardcomes from your own card list (cardListin Onyx), so another member's travel card resolved toundefinedand fell back to the generic Expensify Card icon. The card name column worked for everyone because that string is resolved on the backend and ships on the transaction.The backend now sends
feedCountryon the transaction, so this keys the icon ontransaction.feedCountry === CONST.TRAVEL.PROGRAM_TRAVEL_USand keepsisTravelCard(card)as a fallback for old cached transactions that predate the field. The icon fix lives inTypeCell, so it covers every surface that renders it (search, report view, unreported expenses, duplicate/merge, recently added). Also keyed the card name column onfeedCountryso another member's travel expense shows the localized name, not just the fixed backend string.Depends on the backend change that adds
feedCountryto the flat search response.Fixed Issues
$ #95078
PROPOSAL:
Tests
Offline tests
feedCountryon the cached transaction, no network call)QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari