Add TypeScript typechecking#77
Conversation
Phase 2a of the #64 split: adds tsgo-based typechecking so later phases (ESLint, tests, real peer-review logic) can build on a type-checked baseline. Co-authored-by: Cursor <cursoragent@cursor.com>
roryabraham
changed the title
Pin the latest tsgo preview so typechecking uses the current native TypeScript compiler build. Co-authored-by: Cursor <cursoragent@cursor.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 677ded40ab
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "expensify-common": "2.0.189" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^25.9.4", |
There was a problem hiding this comment.
This repo's .nvmrc pins the workflow/runtime to Node 24, but the new typecheck dependency pulls Node 25 ambient types. If a future script uses a Node 25-only API, CI typechecking will pass even though the script can fail under the Node 24 version installed by setup-node; pin @types/node to the Node 24 line so the check reflects the actual runtime.
Useful? React with 👍 / 👎.
The previous filter only matched .ts/.mts/.cts, missing plain JS files. Co-authored-by: Cursor <cursoragent@cursor.com>
2 participants
Details
Adds
tsgo-based TypeScript typechecking (tsconfig.json+typechecknpm script +.github/workflows/typecheck.yml).Related Issues
https://github.com/Expensify/Expensify/issues/636197
Manual Tests
cd GitHub-Actions && nvm use && npm install.npm run typecheck.Linked PRs
N/A