Add Oxfmt code formatting#79
Merged
Merged
Conversation
roryabraham
changed the title
Include workflow and action YAML in the Oxfmt check while keeping 4-space indentation for JS/TS. Co-authored-by: Cursor <cursoragent@cursor.com>
The previous filter only matched .js/.ts, missing .mjs/.cjs/.mts/.cts. Co-authored-by: Cursor <cursoragent@cursor.com>
The previous commit introduced double-quoted strings, but this repo's .oxfmtrc.json enforces single quotes, which the Oxfmt check itself would flag. Co-authored-by: Cursor <cursoragent@cursor.com>
…oxfmt # Conflicts: # package-lock.json # package.json
marcochavezf
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds Oxfmt code formatting to the repo:
.oxfmtrc.json—tabWidth: 4,singleQuote: true,trailingComma: "all",bracketSpacing: false,arrowParens: "always",printWidth: 190,singleAttributePerLine: true, matching Expensify's established JS/TS formatting conventions.sortImportsuses Oxfmt's basic case-insensitive sorting with no custom groups, since this repo has no path aliases..github/workflows/oxfmt.yml— CI check usingoxfmt --check .(Oxfmt has a native check-only mode), matching this repo's existing workflow conventions (blacksmith-2vcpu-ubuntu-2404, pinned action SHAs, path-filteredpull_requesttrigger).fmtnpm script (oxfmt --write .) and theoxfmtdevDependency.scripts/verifyPeerReview.tswithnpm run fmt(4-space indent, single quotes, no bracket spacing) so the repo stays consistently formatted going forward.This repo uses Oxfmt (a native Rust formatter) rather than Prettier, consistent with what we now use in App, used here as a reference for config conventions).
Related Issues
https://github.com/Expensify/Expensify/issues/636197
Manual Tests
Ran
npm run fmtlocally — it formatsscripts/verifyPeerReview.tsas expected, andnpx oxfmt --check .passes cleanly afterward. Verified the reformatted script still runs correctly.Linked PRs
N/A