Fix intermittent freeze on exit#160
Open
leidenwolcloud wants to merge 5 commits intoExpiredPopsicle:mainfrom
Open
Fix intermittent freeze on exit#160leidenwolcloud wants to merge 5 commits intoExpiredPopsicle:mainfrom
leidenwolcloud wants to merge 5 commits intoExpiredPopsicle:mainfrom
Conversation
copygirl
reviewed
Feb 7, 2026
Comment on lines
+66
to
+68
| var min_hand_detection_confidence = 0.5 | ||
| var min_hand_tracking_confidence = 0.5 | ||
| var min_hand_presence_confidence = 0.5 |
Contributor
There was a problem hiding this comment.
These defaults are different from the hardcoded values before, is that intentional?
(Same when they're being initialized on the python end.)
Author
There was a problem hiding this comment.
0.5 is the default for these values used in MediaPipe Studio hand detection. I'm not sure where the hardcoded values before came from, but I can restore them in the interest of not subtly changing people's setups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78 in the simplest brute force way I could think of: just kill the tracker process instead of calling the stop function through RPC.
If we really need a graceful exit for the tracker, I had some thoughts of trying to use SIGTERM or CTRL_BREAK_EVENT to terminate the process in a way that hopefully bypasses the backlogged RPC issue.
I also addressed some FIXMEs I found along the way, including refactoring of
update_settings.