Skip to content

fix: migrate agent_ping pipeline configs and surface params.prompt in UI#1169

Merged
chubes4 merged 1 commit intomainfrom
fix-agent-ping-pipeline-migration
Apr 23, 2026
Merged

fix: migrate agent_ping pipeline configs and surface params.prompt in UI#1169
chubes4 merged 1 commit intomainfrom
fix-agent-ping-pipeline-migration

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented Apr 23, 2026

Summary

The agent_ping→system_task migration (shipped in 0.60.0) only converted flow configs. Pipeline configs were missed, leaving orphaned agent_ping steps in the pipeline UI with no visible prompt.

Problem

  • Pipeline steps still had step_type: 'agent_ping' (no longer a registered step type)
  • React UI showed raw slug 'agent_ping' instead of a label
  • The prompt was nested at handler_configs.system_task.params.prompt, but FlowStepCard only looked for top-level handler_config.prompt
  • Result: no prompt field rendered anywhere in the UI

Changes

Backend

  • New migration datamachine_migrate_agent_ping_pipeline_to_system_task() with its own idempotency flag (datamachine_agent_ping_pipeline_migrated) to convert agent_ping steps in datamachine_pipelines
  • Called from data-machine.php activation hook alongside the existing flow migration

React UI

  • FlowStepCard.jsx: detect and render params.prompt for system_task steps; save edits back into params.prompt instead of top-level prompt
  • PipelineStepCard.jsx: add legacy fallback label for agent_ping and show system_task task name badge (e.g. "Agent Ping")

Verification

  • Cross-site scan confirmed only extrachill.com (main site, blog 1) has affected pipelines (IDs 4, 5, 6 — 3 duplicate "Agent Pings"). Events (7) and Wire (11) are clean.

Deployment Notes

After deploy, the new migration will run automatically on plugin activation. The 3 duplicate Agent Pings pipelines may need manual cleanup post-migration.

The agent_ping→system_task migration (0.60.0) only converted flow configs.
Pipeline configs were missed, leaving orphaned agent_ping steps in the
pipeline UI with no visible prompt.

Changes:
- Add datamachine_migrate_agent_ping_pipeline_to_system_task() migration
  with its own idempotency flag to convert agent_ping steps in
  datamachine_pipelines.
- FlowStepCard: detect and render params.prompt for system_task steps,
  and save edits back into params.prompt instead of top-level prompt.
- PipelineStepCard: add legacy fallback label for agent_ping and show
  system_task task name badge (e.g. 'Agent Ping').

Fixes UI regression where agent ping pipelines showed raw 'agent_ping'
step type with no editable prompt.
@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented Apr 23, 2026

Homeboy Results — data-machine

Audit

⚡ Scope: changed files only

audit (changed files only)

  • Alignment score: 0.803
  • Outliers in current run: 45
  • Drift increased: no
  • Severity counts: info: 12, unknown: 45, warning: 40
  • Top actionable findings:
    1. inc/Engine/AI/Directives/DirectiveOutputValidator.php — naming_mismatch — Helper-like name does not match convention suffix 'Directive': DirectiveOutputValidator
    2. inc/Abilities/Flow/FlowHelpers.php — naming_mismatch — Helper-like name does not match convention suffix 'Ability': FlowHelpers
    3. inc/Abilities/FlowStep/FlowStepHelpers.php — naming_mismatch — Helper-like name does not match convention suffix 'Ability': FlowStepHelpers
    4. inc/Abilities/Job/JobHelpers.php — naming_mismatch — Helper-like name does not match convention suffix 'Ability': JobHelpers
    5. data-machine.php — high_item_count — File has 17 top-level items (threshold: 15)
    6. data-machine.php — intra_method_duplicate — Duplicated block in datamachine_check_requirements — 5 identical lines at line 731 and line 749
    7. inc/Abilities/Flow/CreateFlowAbility.php — intra_method_duplicate — Duplicated block in executeBulk — 6 identical lines at line 358 and line 389
    8. inc/Abilities/FlowStep/FlowStepHelpers.php — intra_method_duplicate — Duplicated block in updateUserMessage — 5 identical lines at line 524 and line 539
    9. inc/Core/Steps/Upsert/Handlers/WordPress/WordPress.php — intra_method_duplicate — Duplicated block in registerTools — 6 identical lines at line 64 and line 86
    10. inc/Engine/Actions/ImportExport.php — intra_method_duplicate — Duplicated block in ensure_flow — 5 identical lines at line 292 and line 303
Audit findings (10 shown)
1. **inc/Engine/AI/Directives/DirectiveOutputValidator.php** — naming_mismatch — Helper-like name does not match convention suffix 'Directive': DirectiveOutputValidator
2. **inc/Abilities/Flow/FlowHelpers.php** — naming_mismatch — Helper-like name does not match convention suffix 'Ability': FlowHelpers
3. **inc/Abilities/FlowStep/FlowStepHelpers.php** — naming_mismatch — Helper-like name does not match convention suffix 'Ability': FlowStepHelpers
4. **inc/Abilities/Job/JobHelpers.php** — naming_mismatch — Helper-like name does not match convention suffix 'Ability': JobHelpers
5. **data-machine.php** — high_item_count — File has 17 top-level items (threshold: 15)
6. **data-machine.php** — intra_method_duplicate — Duplicated block in `datamachine_check_requirements` — 5 identical lines at line 731 and line 749
7. **inc/Abilities/Flow/CreateFlowAbility.php** — intra_method_duplicate — Duplicated block in `executeBulk` — 6 identical lines at line 358 and line 389
8. **inc/Abilities/FlowStep/FlowStepHelpers.php** — intra_method_duplicate — Duplicated block in `updateUserMessage` — 5 identical lines at line 524 and line 539
9. **inc/Core/Steps/Upsert/Handlers/WordPress/WordPress.php** — intra_method_duplicate — Duplicated block in `registerTools` — 6 identical lines at line 64 and line 86
10. **inc/Engine/Actions/ImportExport.php** — intra_method_duplicate — Duplicated block in `ensure_flow` — 5 identical lines at line 292 and line 303
Tooling versions
  • Homeboy CLI: homeboy 0.89.1+7cd9e346
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: unknown
  • Action: Extra-Chill/homeboy-action@v2

Homeboy Action v1

@chubes4 chubes4 merged commit 1a59f40 into main Apr 23, 2026
1 check passed
@chubes4 chubes4 deleted the fix-agent-ping-pipeline-migration branch April 23, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant