fix: migrate agent_ping pipeline configs and surface params.prompt in UI#1169
Merged
fix: migrate agent_ping pipeline configs and surface params.prompt in UI#1169
Conversation
The agent_ping→system_task migration (0.60.0) only converted flow configs. Pipeline configs were missed, leaving orphaned agent_ping steps in the pipeline UI with no visible prompt. Changes: - Add datamachine_migrate_agent_ping_pipeline_to_system_task() migration with its own idempotency flag to convert agent_ping steps in datamachine_pipelines. - FlowStepCard: detect and render params.prompt for system_task steps, and save edits back into params.prompt instead of top-level prompt. - PipelineStepCard: add legacy fallback label for agent_ping and show system_task task name badge (e.g. 'Agent Ping'). Fixes UI regression where agent ping pipelines showed raw 'agent_ping' step type with no editable prompt.
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The agent_ping→system_task migration (shipped in 0.60.0) only converted flow configs. Pipeline configs were missed, leaving orphaned
agent_pingsteps in the pipeline UI with no visible prompt.Problem
step_type: 'agent_ping'(no longer a registered step type)'agent_ping'instead of a labelhandler_configs.system_task.params.prompt, butFlowStepCardonly looked for top-levelhandler_config.promptChanges
Backend
datamachine_migrate_agent_ping_pipeline_to_system_task()with its own idempotency flag (datamachine_agent_ping_pipeline_migrated) to convertagent_pingsteps indatamachine_pipelinesdata-machine.phpactivation hook alongside the existing flow migrationReact UI
FlowStepCard.jsx: detect and renderparams.promptforsystem_tasksteps; save edits back intoparams.promptinstead of top-levelpromptPipelineStepCard.jsx: add legacy fallback label foragent_pingand showsystem_tasktask name badge (e.g."Agent Ping")Verification
Deployment Notes
After deploy, the new migration will run automatically on plugin activation. The 3 duplicate Agent Pings pipelines may need manual cleanup post-migration.