Conversation
install_skills now copies every skill under the repo's own skills/ directory (currently upgrade-wp-coding-agents and wp-coding-agents-setup) into the runtime skills dir before falling back to the external skill repos. The in-repo skills were never deployed to live installs, so /upgrade-wp-coding-agents was missing on every configured runtime. On Claude Code and Studio Code, the Data Machine workspace was only added to permissions.additionalDirectories. That grants file-tool access but the Bash tool is gated by explicit allow rules, so ls / git / studio wp datamachine-code … inside the workspace still prompted. The hook installer now also merges Read/Edit/Write globs for the workspace and Bash allow patterns for the datamachine-code workspace, github, and gitsync command families. Prefix adapts to Studio vs VPS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_skillsnow copies every skill shipped under the repo's ownskills/directory (today:upgrade-wp-coding-agents,wp-coding-agents-setup) into the runtime skills dir. Previously these were never deployed to live installs, so/upgrade-wp-coding-agentswas missing on every configured runtime and the only way to pull the latest was tocd ~/Developer/wp-coding-agents && ./upgrade.shby hand.Claude Code + Studio Code hook installers used to add the Data Machine workspace only to
permissions.additionalDirectories. That covers the Read/Edit/Write tools but the Bash tool is gated by explicitallowrules, so everyls/git/studio wp datamachine-code …inside the workspace still prompted. Both runtimes now also merge:Read/Edit/Write($DM_WORKSPACE_DIR/**)Bash(<wp_prefix> datamachine-code workspace:*),… github:*,… gitsync:*wp_prefixisstudio wpon Studio installs and barewpon VPS installs, matching the rest of the runtime's command display logic. OpenCode already uses its nativepermission.external_directorymodel, so no change there.Both changes are idempotent: in-repo skill copies now
rm -rfthe target first, and the jq / Python merges dedupe against existing entries.Test plan
bash -n lib/skills.sh runtimes/claude-code.sh runtimes/studio-code.sh— syntax cleaninstall_skillsdry-run withDRY_RUN=true INSTALL_SKILLS=true INSTALL_DATA_MACHINE=trueemitsWould install in-repo skill: upgrade-wp-coding-agentsand… wp-coding-agents-setupbefore the two remote clonespermissions.allowentries, preserves existing rules, and dedupes on re-run./setup.sh --skills-onlyon a Studio install and confirm$SITE_PATH/.claude/skills/upgrade-wp-coding-agents/appears./upgrade.sh --skills-onlyon an existing Studio install and confirm the same.claude/settings.jsoncontains the newpermissions.allowrules and that reading a file under$DATAMACHINE_WORKSPACE_PATHno longer prompts