feat!: make Data Machine mandatory, drop --no-data-machine#59
Merged
Conversation
wp-coding-agents composes on top of Data Machine — memory files, auto-
composed AGENTS.md, skills, workspace primitive, MCP surface. Without DM
the installer degrades to "npm i -g claude + write a settings.json,"
which is not a product.
Breaking: `--no-data-machine` is removed from setup.sh and upgrade.sh.
Everyone gets DM. If a user changes their mind after the fact they can
disable/uninstall the plugin via the admin UI.
Managed-host framing is also dropped: wp-coding-agents is a local/VPS
installer that runs node, npm, and systemd/launchd, so it was never
going to work on WP.com / VIP / Pressable regardless of DM. The Data
Machine plugin on its own is a normal WP plugin and can run on managed
hosts — that's a separate onboarding path, not a setup.sh flag.
Scope of cleanup:
- setup.sh: drop flag, default, and help entry. Shebang comment reframes
DM as substrate.
- upgrade.sh: drop INSTALL_DATA_MACHINE default + the guard around
regenerate_agents_md. Drift-check now always announces DM plugin
install in dry-run.
- lib/data-machine.sh: drop --no-data-machine skip branch from
install_data_machine and create_dm_agent.
- lib/skills.sh: Data Machine skills repo is now always cloned.
- lib/detect.sh / lib/summary.sh: drop DM conditionals and credentials
field. Summary unconditionally prints the DM block.
- lib/repair-opencode-json.py: drop required --install-dm arg; the
`dm-context-filter.ts` + `dm-agent-sync.ts` plugins are now keyed on
CHAT_BRIDGE == kimaki alone.
- runtimes/claude-code.sh, studio-code.sh, opencode.sh:
- runtime_discover_dm_paths: drop early-return on !DM.
- runtime_generate_config: collapse IF_DATA_MACHINE / IF_NO_DATA_MACHINE
branching into a single DM-included code path. CLAUDE.md template
loses its conditional sentinels; only the Studio conditional remains.
- runtime_install_hooks: drop early-return on !DM. SessionStart hook
+ workspace allow rules always install.
- runtime_generate_instructions: `wp datamachine agent compose AGENTS.md`
is now the default; static template remains only as a dry-run /
compose-failure fallback.
- opencode permission block + DM kimaki plugins always wire up.
- workspace/CLAUDE.md.tmpl: remove {{IF_DATA_MACHINE}} /
{{IF_NO_DATA_MACHINE}} sentinel pair.
- README.md: drop --no-data-machine row, reframe the old "With/Without
DM" section as "What Data Machine Gives You."
- skills/wp-coding-agents-setup/SKILL.md: drop Autonomous Operation
question (Q3 — was the --no-data-machine proxy), drop the "no DM"
command table rows, renumber remaining questions.
docs/changelog.md is untouched (historical entries stay accurate;
CHANGELOG is regenerated from commits at release per repo convention).
With DM mandatory, "When Data Machine is installed, …" and "only when DM memory is surfaced via Kimaki" read as vestigial. Rewrite them to pin the real condition: the chat bridge being Kimaki, since that's what actually gates the dm-context-filter / dm-agent-sync plugins. - README.md: Kimaki "Filter redundant context" bullet drops the DM clause. - runtimes/opencode.sh: comment above the Kimaki plugins block pins on "bridge is Kimaki" instead of "DM memory surfaced via Kimaki". - lib/repair-opencode-json.py: same comment update in expected_plugins(). No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking change. wp-coding-agents composes on top of Data Machine — memory files (SOUL/MEMORY/USER/RULES/SITE), auto-composed AGENTS.md, skills, workspace primitive, MCP surface, conversation storage. Without DM the installer degrades to "npm i -g claude + write a settings.json", which is not a product. This PR makes DM mandatory.
If a user changes their mind post-install, the graceful out is `wp plugin deactivate data-machine` / uninstall via the admin UI. No flag required.
Managed-host framing is also dropped. wp-coding-agents is a local/VPS installer that runs node, npm, and systemd/launchd — it was never compatible with WP.com / VIP / Pressable regardless of DM. The Data Machine and Data Machine Code plugins on their own are normal WP plugins and do run on managed hosts; that's a separate onboarding path (admin plugin uploader → connect MCP → point a remote coding agent at the URL), not a `setup.sh` flag.
What changed
`docs/changelog.md` is untouched — historical entries stay accurate; CHANGELOG regenerates from commits at release per repo convention.
Net: 190 lines removed, 87 added.
Test plan
@includes, allow rules landFollow-up (not this PR)