Skip to content

Bootstrap test data from JSON fixtures instead of SQL migrations #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
dennisvang wants to merge 10 commits into
base: feature/634-boostrapping-fdp
Choose a base branch
from
Draft

Bootstrap test data from JSON fixtures instead of SQL migrations #802

dennisvang wants to merge 10 commits into from

Conversation

@dennisvang
Copy link
Contributor

@dennisvang dennisvang commented Nov 13, 2025 •
edited
Loading

Replace SQL test data migrations by JSON test data fixtures.

  • remove reference to test data migration files from flyway test config
  • remove test data migration files (*.sql)
  • add corresponding test data fixture files (*.json) (extend default fixtures, do not duplicate)
  • specify test data location in bootstrap test config (depends on Enable loading of relational db fixtures from multiple directories #793)
  • get repository populator to run again before each test (because flyway clean is called before each test)

@dennisvang dennisvang mentioned this pull request Nov 13, 2025
Draft
8 tasks
@dennisvang dennisvang changed the title Remove sql test data migrations Replace SQL test data migrations by JSON test data fixtures Nov 13, 2025
@dennisvang dennisvang changed the title Replace SQL test data migrations by JSON test data fixtures Bootstrap test data from JSON fixtures instead of SQL migrations Nov 13, 2025
@dennisvang dennisvang force-pushed the proposal/634-remove-sql-test-data-migrations branch from 4d9f371 to 0a80643 Compare November 13, 2025 16:56
@dennisvang dennisvang self-assigned this Nov 13, 2025
@dennisvang
rename 'db-fixtures-dirs' property to 'locations'
319b1b4 
this is more consistent with e.g. the 'locations' option for flyway
@dennisvang
rename fixturesDir loop variable to location
9295809
@dennisvang
remove 'file:' prefix from fixture location pattern
c7f111b 
This allows us to include the prefix in the config, which is more flexible.
For example, we can set file:fixtures for the default fixtures,
which need to be overridable in the docker container,
and we can set classpath:test-fixtures for the test fixtures,
which can then be included in the test/resources dir.

Moreover, this approach is similar to the way flyway.locations are specified.
@dennisvang
clarify RepositoriesPopulatedEvent log message
39b4dce 
the populator is done, but that does not necessarily mean any repositories were actually populated
@dennisvang
Revert "remove data migrations from src/test/resources/test/db"
c6386c9 
This reverts commit 1ac2639.
@dennisvang
replace V0001.1__dev-data-users.sql test data migration by json fixtu…
0739c42 
…re file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dennisvang dennisvang

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dennisvang