Type checking fixes #393
Open
Type checking fixes #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g type hinting to avoid circular imports.
…s no attribute 'color'" and "'Embed' object attribute 'color' is read-only"
…h. Fixed the issue with format exception parameters. Added the get_command and walk_commands methods with correct types to avoid errors.
…e hints to database stuff, and fix some stuff with the require_team and send_on_verify.
…return the right type. Added type hints in some other places. Moved GuildNewMember to actionlogs.py to avoid circular import and make some stuff simpler.
…t theres more type hints.
…hanged some stuff so slash commands dont die with too big ints.
JayFromProgramming
requested changes
Oct 22, 2022
Member
JayFromProgramming
left a comment
JayFromProgramming
left a comment
There was a problem hiding this comment.
Too many merge conflicts for me to approve
Contributor
Author
|
I'll fix all of them once I'm back at a computer. |
BCurbs
requested review from
JayFromProgramming
and removed request for
tweirtx
JayFromProgramming
requested changes
May 4, 2023
Member
JayFromProgramming
left a comment
JayFromProgramming
left a comment
There was a problem hiding this comment.
There are too many changes in this PR for me to in good faith approve it, please split this into separate pull requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added wayyyyyy more type checking. I even fixed the merge conflicts and the pylint.