Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions architecture_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,23 +70,6 @@ func TestStoreCreateGameDoesNotUseNameDerivedRunMetadata(t *testing.T) {
})
}

func TestPDFExportPackageDoesNotContainMarkdownParseEntrypoints(t *testing.T) {
assertFilesDoNotContain(t, "pdfexport", []string{
"func ParseMarkdown(",
"func ParseFile(",
"func ParseFiles(",
"func lookupMarkdownBodyParser(",
})
}

func TestGamePackageDoesNotExposeLegacyPrintFacade(t *testing.T) {
if _, err := os.Stat(filepath.Join("game", "print_adapter.go")); err == nil {
t.Fatal("game/print_adapter.go should not exist")
} else if !os.IsNotExist(err) {
t.Fatalf("stat game/print_adapter.go: %v", err)
}
}

func assertPackageDoesNotImport(t *testing.T, dir string, forbidden []string) {
t.Helper()

Expand Down
4 changes: 2 additions & 2 deletions nurikabe/nurikabe_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,13 @@ func TestGridStringAndParse(t *testing.T) {
}
}

func TestParseGridLegacyRequiredLand(t *testing.T) {
func TestParseGridMapsRequiredLandMarkerToIsland(t *testing.T) {
g, err := parseGrid("?!\n~o", 2, 2)
if err != nil {
t.Fatalf("parseGrid error: %v", err)
}
if g[0][1] != islandCell {
t.Fatalf("legacy required-land marker should load as island, got %q", rune(g[0][1]))
t.Fatalf("required-land marker should load as island, got %q", rune(g[0][1]))
}
}

Expand Down
2 changes: 1 addition & 1 deletion store/store_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func TestOpen(t *testing.T) {
}
})

t.Run("upgrades legacy databases and backfills metadata", func(t *testing.T) {
t.Run("upgrades databases missing run metadata and backfills it", func(t *testing.T) {
dbPath := filepath.Join(t.TempDir(), "legacy.db")

raw, err := sql.Open("sqlite", dbPath)
Expand Down
2 changes: 1 addition & 1 deletion ui/ui_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func TestMenuItemActionID(t *testing.T) {
}
})

t.Run("falls back to title for legacy callers", func(t *testing.T) {
t.Run("falls back to title when action is unset", func(t *testing.T) {
item := MenuItem{ItemTitle: "Generate"}
if got := item.ActionID(); got != "Generate" {
t.Fatalf("ActionID() = %q, want %q", got, "Generate")
Expand Down
Loading