Validate hotkey when setting it#1770
Merged
jjw24 merged 14 commits intoFlow-Launcher:devfrom Jan 18, 2023
Merged
Conversation
taooceros
reviewed
Jan 9, 2023
jjw24
previously requested changes
Jan 10, 2023
Member
jjw24
left a comment
There was a problem hiding this comment.
Can we:
- When a hotkey is unavailable, stay focused inside the text box so user can continue to try new hotkey.
- When clicked away and the hotkey is unavailable, return to the previous set hotkey.
Member
|
I just remember I have a very old pr regarding this #933. Well but it is a bit hacky.... |
d7a7d9b to
835370a
Compare
Contributor
Author
|
Closed by accident somehow. |
Contributor
Author
Please review again. |
Closed
| { | ||
| return !((CharKey >= Key.A && CharKey <= Key.Z) || | ||
| (CharKey >= Key.D0 && CharKey <= Key.D9) || | ||
| (CharKey >= Key.NumPad0 && CharKey <= Key.NumPad9)); |
Contributor
Author
There was a problem hiding this comment.
Checking for all symbol keys are too difficult so I just ban alphanumeric keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests: