Pydantic upgrade #26
Open
Pydantic upgrade #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the pydantic constraint and replaces all pydantic api calls to the back-compatible `pydantic.v1`. Also rebulds requirements.txt and dev-requirements.txt.
greenape
suggested changes
Jul 2, 2025
| from fastapi import HTTPException | ||
| from fastapi.params import Depends | ||
| from pydantic import SecretStr | ||
| from pydantic.v1 import SecretStr |
Contributor
There was a problem hiding this comment.
Presumably the v1 import actually means we now need to constrain to >= 2?
Contributor
Author
|
Yeah, that might sort out the issue with the tests. Lets see.
…On Wed, 2 Jul 2025 at 13:26, Jonathan Gray ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In flowkit_ui_backend/impl/accounts_api_impl.py
<#26 (comment)>
:
> @@ -11,7 +11,7 @@
from cachetools import TTLCache
from fastapi import HTTPException
from fastapi.params import Depends
-from pydantic import SecretStr
+from pydantic.v1 import SecretStr
Presumably the v1 import actually means we now need to constrain to >= 2?
—
Reply to this email directly, view it on GitHub
<#26 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXIU24RCDJN6LES5DFMLZ33GPFXLAVCNFSM6AAAAACATLKPKGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNZYHE2DMMJSGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the pydantic constraint and replaces all
pydantic api calls to the back-compatible
pydantic.v1. Also rebulds requirements.txt and dev-requirements.txt.