Repository navigation
Prevent reentrant self-sizing layout on iPhone Duo - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-sizing sheets can synchronously reenter their host's layout when body bounds change during
.autoPointsFromBottommeasurement. The reported Duo stack repeats the container notification and host layout until it crashes.Separate body-bounds observations from explicit sizing requests and guard the whole host layout transaction. Defer reentrant requests until the current UIKit stack returns, preserving the previous vertical geometry so supplied animators can animate the new height. Coalesce mixed requests without dropping animator completions, retain safe-area propagation before fitting, and avoid redundant constraint assignments.
Validation:
EXC_BAD_ACCESS, or unsatisfiable-constraint messages during this pass.The 2.5.0 backport is preserved on
muukii/prevent-self-sizing-layout-reentry; this PR retains main's current drag handling and intrinsic-size observation.