Remove allocations and improve performance #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeertvanHorrik
requested review from
SimonCropp,
ltrzesniewski and
tom-englert
ltrzesniewski
approved these changes
Feb 23, 2025
Member
ltrzesniewski
left a comment
ltrzesniewski
left a comment
There was a problem hiding this comment.
LGTM 👍
- I cleaned up some stuff while reviewing
- The readme would need an update after this change
Member
Author
|
Beautiful cleanup, thank you. I started working on the nullable things, but didn't want to mix it into this PR, but will do it in a next PR. Also updated the readme. |
Member
|
lgtm. want me to deploy? |
Member
Author
yes please, thank you! I will create another PR after the release to introduce nullable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
Stopwatch.GetTimestampinstead of creating a new stopwatch which results in both memory and performance improvements.Fixes #575